On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>> We were restoring the IRQ masks then clearing them again, because
>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>> work as intended.
>>
>> Signed-off-by: Hector Martin <[email protected]>
>> ---
>> drivers/tty/serial/samsung_tty.c | 1 +
>> include/linux/serial_s3c.h | 3 +++
>> 2 files changed, 4 insertions(+)
>
> Does this fix a specific older commit?
>
> And should it be backported to older stable kernels?
It does fix the commit that introduced this device support in general; I
can add a Fixes line for that. I don't think anyone cares about
backporting though, since there are other fairly critical devices that
don't have support outright and there's still work to do before
suspend/resume is generally usable on these machines.
--
Hector Martin ([email protected])
Public Key: https://mrcn.st/pub
On 02/05/2022 14:39, Hector Martin wrote:
> On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
>> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>>> We were restoring the IRQ masks then clearing them again, because
>>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>>> work as intended.
>>>
>>> Signed-off-by: Hector Martin <[email protected]>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 1 +
>>> include/linux/serial_s3c.h | 3 +++
>>> 2 files changed, 4 insertions(+)
>>
>> Does this fix a specific older commit?
>>
>> And should it be backported to older stable kernels?
>
> It does fix the commit that introduced this device support in general; I
> can add a Fixes line for that. I don't think anyone cares about
> backporting though, since there are other fairly critical devices that
> don't have support outright and there's still work to do before
> suspend/resume is generally usable on these machines.
Then please add only Fixes tag.
Best regards,
Krzysztof