2021-04-26 18:42:42

by Randy Dunlap

Subject: [PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM to fix link errors

With REGULATOR_ROHM there are linker errors:

ld: drivers/regulator/bd71815-regulator.o: in function `set_hw_dvs_levels':
bd71815-regulator.c:(.text+0xbb): undefined reference to `rohm_regulator_set_dvs_levels'
ld: drivers/regulator/bd71815-regulator.o: in function `buck12_set_hw_dvs_levels':
bd71815-regulator.c:(.text+0x33e): undefined reference to `rohm_regulator_set_dvs_levels'

Fixes: 1aad39001e851 ("regulator: Support ROHM BD71815 regulators")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Matti Vaittinen <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Liam Girdwood <[email protected]>
Cc: Mark Brown <[email protected]>
---
Sorry about the Resend. I'm having some email problems.

drivers/regulator/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20210426.orig/drivers/regulator/Kconfig
+++ linux-next-20210426/drivers/regulator/Kconfig
@@ -207,6 +207,7 @@ config REGULATOR_BD70528
config REGULATOR_BD71815
tristate "ROHM BD71815 Power Regulator"
depends on MFD_ROHM_BD71828
+ select REGULATOR_ROHM
help
This driver supports voltage regulators on ROHM BD71815 PMIC.
This will enable support for the software controllable buck

2021-04-27 04:24:23

by Matti Vaittinen

Subject: Re: [PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM to fix link errors

Morning Randy,

On Mon, 2021-04-26 at 11:37 -0700, Randy Dunlap wrote:
> With REGULATOR_ROHM there are linker errors:
>
> ld: drivers/regulator/bd71815-regulator.o: in function
> `set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0xbb): undefined reference to
> `rohm_regulator_set_dvs_levels'
> ld: drivers/regulator/bd71815-regulator.o: in function
> `buck12_set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0x33e): undefined reference to
> `rohm_regulator_set_dvs_levels'
>
> Fixes: 1aad39001e851 ("regulator: Support ROHM BD71815 regulators")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Matti Vaittinen <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: Liam Girdwood <[email protected]>
> Cc: Mark Brown <[email protected]>
> ---
> Sorry about the Resend. I'm having some email problems.

Thanks for fixing this. I just wanted to let you know Arnd sent same
fix (and couple of other fixes to BD71815) few days ago. Mark couldn't
take the patches as the original series is only in Lee's tree. Sorry
for causing the problems.

Best Regards
Matti Vaittinen