2017-06-30 07:15:41

by Gustavo A. R. Silva

Subject: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/devfreq/rk3399_dmc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 40a2499..1b89ebb 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
- return -EINVAL;
+ dev_err(&pdev->dev,
+ "Cannot get the dmc interrupt resource: %d\n", irq);
+ return irq;
}
data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
if (!data)
--
2.5.0

2017-06-30 08:03:11

by Chanwoo Choi

Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

Hi,

On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/devfreq/rk3399_dmc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 40a2499..1b89ebb 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
> - return -EINVAL;
> + dev_err(&pdev->dev,
> + "Cannot get the dmc interrupt resource: %d\n", irq);
> + return irq;
> }
> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
> if (!data)
>

Reviewed-by: Chanwoo Choi <[email protected]>

--
Best Regards,
Chanwoo Choi
Samsung Electronics

2017-07-01 07:51:07

by MyungJoo Ham

Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <[email protected]> wrote:
> Hi,
>
> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
>> Print and propagate the return value of platform_get_irq on failure.
>>
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>> ---
>> drivers/devfreq/rk3399_dmc.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
>> index 40a2499..1b89ebb 100644
>> --- a/drivers/devfreq/rk3399_dmc.c
>> +++ b/drivers/devfreq/rk3399_dmc.c
>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>>
>> irq = platform_get_irq(pdev, 0);
>> if (irq < 0) {
>> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
>> - return -EINVAL;
>> + dev_err(&pdev->dev,
>> + "Cannot get the dmc interrupt resource: %d\n", irq);
>> + return irq;
>> }
>> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>> if (!data)
>>
>
> Reviewed-by: Chanwoo Choi <[email protected]>

Acked-by: MyungJoo Ham <[email protected]>

>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics



--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics

2017-07-03 12:59:31

by Gustavo A. R. Silva

Subject: [PATCH v2] devfreq: rk3399_dmc: fix error return code in rk3399_dmcfreq_probe()

platform_get_irq() returns an error code, but the rk3399_dmc
driver ignores it and always returns -EINVAL. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

Reviewed-by: Chanwoo Choi <[email protected]>
Acked-by: MyungJoo Ham <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
Changes in v2:
Rewrite commit message.

drivers/devfreq/rk3399_dmc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 40a2499..1b89ebb 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
- return -EINVAL;
+ dev_err(&pdev->dev,
+ "Cannot get the dmc interrupt resource: %d\n", irq);
+ return irq;
}
data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
if (!data)
--
2.5.0

2017-07-17 04:51:09

by Gustavo A. R. Silva

Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

On 07/01/2017 02:50 AM, MyungJoo Ham wrote:
> On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <[email protected]> wrote:
>> Hi,
>>
>> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
>>> Print and propagate the return value of platform_get_irq on failure.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>>> ---
>>> drivers/devfreq/rk3399_dmc.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
>>> index 40a2499..1b89ebb 100644
>>> --- a/drivers/devfreq/rk3399_dmc.c
>>> +++ b/drivers/devfreq/rk3399_dmc.c
>>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>>>
>>> irq = platform_get_irq(pdev, 0);
>>> if (irq < 0) {
>>> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
>>> - return -EINVAL;
>>> + dev_err(&pdev->dev,
>>> + "Cannot get the dmc interrupt resource: %d\n", irq);
>>> + return irq;
>>> }
>>> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>>> if (!data)
>>>
>>
>> Reviewed-by: Chanwoo Choi <[email protected]>
>
> Acked-by: MyungJoo Ham <[email protected]>
>

Thank you, Chanwoo and MyungJoo.

--
Gustavo A. R. Silva