2022-11-16 20:07:55

by Anand Moon

Subject: [linux-next-v2 3/5] arm64: dts: rockchip: Add support of regulator for ethernet node on Rock 3A SBC

Add regulator support for ethernet node

Fix following warning.
[ 7.365199] rk_gmac-dwmac fe010000.ethernet: no regulator found

Signed-off-by: Anand Moon <[email protected]>
---
v2: new patch added
---
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index b848282ea005..5378254c57ca 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -260,6 +260,7 @@ &gmac1 {
clock_in_out = "input";
phy-handle = <&rgmii_phy1>;
phy-mode = "rgmii";
+ phy-supply = <&vcc_3v3>;
pinctrl-names = "default";
pinctrl-0 = <&gmac1m1_miim
&gmac1m1_tx_bus2
--
2.38.1

2022-11-22 11:58:06

by Michael Riesch

Subject: Re: [linux-next-v2 3/5] arm64: dts: rockchip: Add support of regulator for ethernet node on Rock 3A SBC

Hi Anand,

On 11/16/22 21:01, Anand Moon wrote:
> Add regulator support for ethernet node
>
> Fix following warning.
> [ 7.365199] rk_gmac-dwmac fe010000.ethernet: no regulator found
>
> Signed-off-by: Anand Moon <[email protected]>

Acked-by: Michael Riesch <[email protected]>
Tested-by: Michael Riesch <[email protected]>

Best regards,
Michael

> ---
> v2: new patch added
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index b848282ea005..5378254c57ca 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -260,6 +260,7 @@ &gmac1 {
> clock_in_out = "input";
> phy-handle = <&rgmii_phy1>;
> phy-mode = "rgmii";
> + phy-supply = <&vcc_3v3>;
> pinctrl-names = "default";
> pinctrl-0 = <&gmac1m1_miim
> &gmac1m1_tx_bus2