2017-06-13 20:16:36

by Dave Gerlach

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

Santosh,
On 05/31/2017 11:28 AM, Rob Herring wrote:
> On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote:
>> Commit 7cc119f29b19 ("dt-bindings: Add TI SCI PM Domains") introduced a
>> number of K2G_DEV_x macros to represent each device ID available on the
>> K2G platform for use by the genpd, clock, and reset drivers. Rather than
>> use these macros, which are only used in the device tree for property
>> values and not actually used by the drivers, let's just use the device
>> ID number directly in the device tree to avoid macro bloat.
>>
>> Signed-off-by: Dave Gerlach <[email protected]>
>> ---
>> Based on discussion here [1] it was agreed that these macros are not needed
>> and it is better to just use the device IDs directly in dt.
>>
>> [1] https://www.spinics.net/lists/arm-kernel/msg577079.html
>>
>> .../devicetree/bindings/soc/ti/sci-pm-domain.txt | 5 +-
>> include/dt-bindings/genpd/k2g.h | 90 ----------------------
>> 2 files changed, 3 insertions(+), 92 deletions(-)
>> delete mode 100644 include/dt-bindings/genpd/k2g.h
>
> Acked-by: Rob Herring <[email protected]>
>

Gentle ping on this. If you're OK with the patch any chance you can pick it up?

Regards,
Dave


2017-06-13 20:32:28

by Santosh Shilimkar

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

On 6/13/2017 1:16 PM, Dave Gerlach wrote:
> Santosh,
> On 05/31/2017 11:28 AM, Rob Herring wrote:
>> On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote:
[...]

>>> [1] https://www.spinics.net/lists/arm-kernel/msg577079.html
>>>
>>> .../devicetree/bindings/soc/ti/sci-pm-domain.txt | 5 +-
>>> include/dt-bindings/genpd/k2g.h | 90 ----------------------
>>> 2 files changed, 3 insertions(+), 92 deletions(-)
>>> delete mode 100644 include/dt-bindings/genpd/k2g.h
>>
>> Acked-by: Rob Herring <[email protected]>
>>
>
> Gentle ping on this. If you're OK with the patch any chance you can pick it up?
>
Sorry Dave I missed to pick this one in pull request for 4.13. Will pick
this
one along with what Suman and Tero have been working for following merge
window. Thanks for reminding about this one.

Regards,
Santosh

2017-06-14 07:09:10

by Tero Kristo

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

On 13/06/17 23:32, Santosh Shilimkar wrote:
> On 6/13/2017 1:16 PM, Dave Gerlach wrote:
>> Santosh,
>> On 05/31/2017 11:28 AM, Rob Herring wrote:
>>> On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote:
> [...]
>
>>>> [1] https://www.spinics.net/lists/arm-kernel/msg577079.html
>>>>
>>>> .../devicetree/bindings/soc/ti/sci-pm-domain.txt | 5 +-
>>>> include/dt-bindings/genpd/k2g.h | 90
>>>> ----------------------
>>>> 2 files changed, 3 insertions(+), 92 deletions(-)
>>>> delete mode 100644 include/dt-bindings/genpd/k2g.h
>>>
>>> Acked-by: Rob Herring <[email protected]>
>>>
>>
>> Gentle ping on this. If you're OK with the patch any chance you can
>> pick it up?
>>
> Sorry Dave I missed to pick this one in pull request for 4.13. Will pick
> this
> one along with what Suman and Tero have been working for following merge
> window. Thanks for reminding about this one.

I think Stephen will probably be picking up the clock part directly by
himself.

-Tero

2017-06-14 17:22:11

by Santosh Shilimkar

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

On 6/14/17 12:07 AM, Tero Kristo wrote:
> On 13/06/17 23:32, Santosh Shilimkar wrote:

[...]

>> Sorry Dave I missed to pick this one in pull request for 4.13. Will
>> pick this
>> one along with what Suman and Tero have been working for following merge
>> window. Thanks for reminding about this one.
>
> I think Stephen will probably be picking up the clock part directly by
> himself.
>
Works for me :-)

Regards,
Santosh