Hi Noralf,
On Saturday 11 Feb 2017 19:48:56 Noralf Tr?nnes wrote:
> Display panels can be oriented many ways, especially in the embedded
> world. The rotation property is a way to describe this orientation.
> The counter clockwise direction is chosen because that's what fbdev
> and drm use.
>
> Signed-off-by: Noralf Tr?nnes <[email protected]>
> Acked-by: Thierry Reding <[email protected]>
> ---
>
> Changes since version 3:
> - Changed display/display.txt -> display/panel/panel.txt
>
> Documentation/devicetree/bindings/display/panel/panel.txt | 4 ++++
We now have both Documentation/devicetree/bindings/display/panel/panel.txt and
Documentation/devicetree/bindings/display/panel/panel-common.txt as they have
been merged concurrently without being aware of each other. Would you mind if
I moved this property to panel-common.txt ?
I would also like to document the property in a bit more details to avoid
confusion about the rotation direction, as "display rotation" could be
interpreted as the angle by which the display output has to be rotated to
obtain an upside-up image. What would you think of the following, am I
overdoing it, or is it even more confusing ?
- rotation: Panels are commonly mounted rotated, with their native orientation
not aligned with the device's orientation. The rotation property specifies the
angle in degrees between the panel's orientation and the device's orientation
(corresponding to a counter-clockwise rotation of the panel). Valid values are
0, 90, 180 and 270.
> 1 file changed, 4 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/panel/panel.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel.txt
> b/Documentation/devicetree/bindings/display/panel/panel.txt new file mode
> 100644
> index 0000000..e2e6867
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel.txt
> @@ -0,0 +1,4 @@
> +Common display properties
> +-------------------------
> +
> +- rotation: Display rotation in degrees counter clockwise (0,90,180,270)
--
Regards,
Laurent Pinchart
Den 11.04.2017 07.29, skrev Laurent Pinchart:
> Hi Noralf,
>
> On Saturday 11 Feb 2017 19:48:56 Noralf Tr?nnes wrote:
>> Display panels can be oriented many ways, especially in the embedded
>> world. The rotation property is a way to describe this orientation.
>> The counter clockwise direction is chosen because that's what fbdev
>> and drm use.
>>
>> Signed-off-by: Noralf Tr?nnes <[email protected]>
>> Acked-by: Thierry Reding <[email protected]>
>> ---
>>
>> Changes since version 3:
>> - Changed display/display.txt -> display/panel/panel.txt
>>
>> Documentation/devicetree/bindings/display/panel/panel.txt | 4 ++++
> We now have both Documentation/devicetree/bindings/display/panel/panel.txt and
> Documentation/devicetree/bindings/display/panel/panel-common.txt as they have
> been merged concurrently without being aware of each other. Would you mind if
> I moved this property to panel-common.txt ?
Not at all, please do.
> I would also like to document the property in a bit more details to avoid
> confusion about the rotation direction, as "display rotation" could be
> interpreted as the angle by which the display output has to be rotated to
> obtain an upside-up image. What would you think of the following, am I
> overdoing it, or is it even more confusing ?
I was more confused at least :-)
It's not important to me what the actual wording is, but I see that I
have used the word 'Display' which should have been 'Panel'.
Noralf.
> - rotation: Panels are commonly mounted rotated, with their native orientation
> not aligned with the device's orientation. The rotation property specifies the
> angle in degrees between the panel's orientation and the device's orientation
> (corresponding to a counter-clockwise rotation of the panel). Valid values are
> 0, 90, 180 and 270.
>
>
>> 1 file changed, 4 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/panel/panel.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel.txt
>> b/Documentation/devicetree/bindings/display/panel/panel.txt new file mode
>> 100644
>> index 0000000..e2e6867
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/panel.txt
>> @@ -0,0 +1,4 @@
>> +Common display properties
>> +-------------------------
>> +
>> +- rotation: Display rotation in degrees counter clockwise (0,90,180,270)