2024-04-19 12:34:54

by Markus Elfring

Subject: [PATCH] scsi: qla2xxx: Use -EIO in qla_get_tmf()

From: Markus Elfring <[email protected]>
Date: Fri, 19 Apr 2024 14:24:56 +0200

Add a minus sign before the error code “EIO”
so that a negative value will eventually be returned
as in another error case.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 8377624d76c9..8d93d9631ba3 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -2281,7 +2281,7 @@ int qla_get_tmf(struct tmf_arg *arg)
if (TMF_NOT_READY(fcport)) {
ql_log(ql_log_warn, vha, 0x802c,
"Unable to acquire TM resource due to disruption.\n");
- rc = EIO;
+ rc = -EIO;
break;
}
if (ha->active_tmf < MAX_ACTIVE_TMF &&
--
2.44.0

2024-04-19 12:47:13

by James Bottomley

Subject: Re: [PATCH] scsi: qla2xxx: Use -EIO in qla_get_tmf()

On Fri, 2024-04-19 at 14:34 +0200, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Fri, 19 Apr 2024 14:24:56 +0200
>
> Add a minus sign before the error code “EIO”
> so that a negative value will eventually be returned
> as in another error case.

No it won't. If you look how it's used the consumer doesn't pass on
the error.

James