2023-06-09 07:15:32

by Jiapeng Chong

Subject: [PATCH] net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy

./net/sched/act_pedit.c:245:21-28: WARNING opportunity for kmemdup.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5478
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/sched/act_pedit.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index fc945c7e4123..8c4e7fddddbf 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -242,14 +242,12 @@ static int tcf_pedit_init(struct net *net, struct nlattr *nla,
nparms->tcfp_flags = parm->flags;
nparms->tcfp_nkeys = parm->nkeys;

- nparms->tcfp_keys = kmalloc(ksize, GFP_KERNEL);
+ nparms->tcfp_keys = kmemdup(parm->keys, ksize, GFP_KERNEL);
if (!nparms->tcfp_keys) {
ret = -ENOMEM;
goto put_chain;
}

- memcpy(nparms->tcfp_keys, parm->keys, ksize);
-
for (i = 0; i < nparms->tcfp_nkeys; ++i) {
u32 offmask = nparms->tcfp_keys[i].offmask;
u32 cur = nparms->tcfp_keys[i].off;
--
2.20.1.7.g153144c

2023-06-09 12:35:02

by Pedro Tammela

Subject: Re: [PATCH] net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy

On 09/06/2023 04:01, Jiapeng Chong wrote:
> ./net/sched/act_pedit.c:245:21-28: WARNING opportunity for kmemdup.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5478
> Signed-off-by: Jiapeng Chong <[email protected]>

LGTM,

Reviewed-by: Pedro Tammela <[email protected]>

> ---
> net/sched/act_pedit.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
> index fc945c7e4123..8c4e7fddddbf 100644
> --- a/net/sched/act_pedit.c
> +++ b/net/sched/act_pedit.c
> @@ -242,14 +242,12 @@ static int tcf_pedit_init(struct net *net, struct nlattr *nla,
> nparms->tcfp_flags = parm->flags;
> nparms->tcfp_nkeys = parm->nkeys;
>
> - nparms->tcfp_keys = kmalloc(ksize, GFP_KERNEL);
> + nparms->tcfp_keys = kmemdup(parm->keys, ksize, GFP_KERNEL);
> if (!nparms->tcfp_keys) {
> ret = -ENOMEM;
> goto put_chain;
> }
>
> - memcpy(nparms->tcfp_keys, parm->keys, ksize);
> -
> for (i = 0; i < nparms->tcfp_nkeys; ++i) {
> u32 offmask = nparms->tcfp_keys[i].offmask;
> u32 cur = nparms->tcfp_keys[i].off;

2023-06-09 16:40:31

by Jamal Hadi Salim

Subject: Re: [PATCH] net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy

On Fri, Jun 9, 2023 at 8:30 AM Pedro Tammela <[email protected]> wrote:
>
> On 09/06/2023 04:01, Jiapeng Chong wrote:
> > ./net/sched/act_pedit.c:245:21-28: WARNING opportunity for kmemdup.
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5478
> > Signed-off-by: Jiapeng Chong <[email protected]>
>
> LGTM,
>
> Reviewed-by: Pedro Tammela <[email protected]>

Acked-by: Jamal Hadi Salim <[email protected]>

cheers,
jamal

> > ---
> > net/sched/act_pedit.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
> > index fc945c7e4123..8c4e7fddddbf 100644
> > --- a/net/sched/act_pedit.c
> > +++ b/net/sched/act_pedit.c
> > @@ -242,14 +242,12 @@ static int tcf_pedit_init(struct net *net, struct nlattr *nla,
> > nparms->tcfp_flags = parm->flags;
> > nparms->tcfp_nkeys = parm->nkeys;
> >
> > - nparms->tcfp_keys = kmalloc(ksize, GFP_KERNEL);
> > + nparms->tcfp_keys = kmemdup(parm->keys, ksize, GFP_KERNEL);
> > if (!nparms->tcfp_keys) {
> > ret = -ENOMEM;
> > goto put_chain;
> > }
> >
> > - memcpy(nparms->tcfp_keys, parm->keys, ksize);
> > -
> > for (i = 0; i < nparms->tcfp_nkeys; ++i) {
> > u32 offmask = nparms->tcfp_keys[i].offmask;
> > u32 cur = nparms->tcfp_keys[i].off;
>

2023-06-12 09:07:02

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Fri, 9 Jun 2023 15:01:17 +0800 you wrote:
> ./net/sched/act_pedit.c:245:21-28: WARNING opportunity for kmemdup.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5478
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> net/sched/act_pedit.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
- net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy
https://git.kernel.org/netdev/net-next/c/26e35370b976

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html