2023-07-26 09:24:04

by Jinjie Ruan

Subject: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()

There is no need to call the dev_err() function directly to print a custom
message when handling an error from the platform_get_irq() functions as it
going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <[email protected]>
---
drivers/misc/hi6421v600-irq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
index caa3de37698b..e5ed94e98a3c 100644
--- a/drivers/misc/hi6421v600-irq.c
+++ b/drivers/misc/hi6421v600-irq.c
@@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)

priv->irq = platform_get_irq(pmic_pdev, 0);
if (priv->irq < 0) {
- dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
return priv->irq;
}

--
2.34.1

2023-07-26 10:49:54

by Greg Kroah-Hartman

Subject: Re: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()

On Wed, Jul 26, 2023 at 05:06:44PM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from the platform_get_irq() functions as it
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <[email protected]>
> ---
> drivers/misc/hi6421v600-irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
> index caa3de37698b..e5ed94e98a3c 100644
> --- a/drivers/misc/hi6421v600-irq.c
> +++ b/drivers/misc/hi6421v600-irq.c
> @@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>
> priv->irq = platform_get_irq(pmic_pdev, 0);
> if (priv->irq < 0) {
> - dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
> return priv->irq;
> }

It's good not to add coding style errors when trying to fix up a
different type of issue :(

2023-07-26 10:56:16

by Jinjie Ruan

Subject: Re: [PATCH -next] misc: hi6421-spmi-pmic: Remove redundant dev_err()

On 2023/7/26 17:42, Greg KH wrote:
> On Wed, Jul 26, 2023 at 05:06:44PM +0000, Ruan Jinjie wrote:
>> There is no need to call the dev_err() function directly to print a custom
>> message when handling an error from the platform_get_irq() functions as it
>> going to display an appropriate error message in case of a failure.
>>
>> Signed-off-by: Ruan Jinjie <[email protected]>
>> ---
>> drivers/misc/hi6421v600-irq.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
>> index caa3de37698b..e5ed94e98a3c 100644
>> --- a/drivers/misc/hi6421v600-irq.c
>> +++ b/drivers/misc/hi6421v600-irq.c
>> @@ -245,7 +245,6 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
>>
>> priv->irq = platform_get_irq(pmic_pdev, 0);
>> if (priv->irq < 0) {
>> - dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
>> return priv->irq;
>> }
>
> It's good not to add coding style errors when trying to fix up a
> different type of issue :(

I'll fix the coding style error in v2, thank you!