2022-09-29 06:07:21

by Randy Dunlap

Subject: [PATCH -next] tty: serial: atmel: driver depends on COMMON_CLK

Since atmel_serial.c uses interfaces that are provided by
the COMMON_CLK Kconfig symbol, the driver should depend on
COMMON_CLK to prevent build errors.

ld: drivers/tty/serial/atmel_serial.o: in function `atmel_serial_pm':
atmel_serial.c:(.text+0x1553): undefined reference to `__clk_is_enabled'
ld: drivers/tty/serial/atmel_serial.o: in function `atmel_set_termios':
atmel_serial.c:(.text+0x1dfe): undefined reference to `__clk_is_enabled'

Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Sergiu Moga <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Richard Genoud <[email protected]>
Cc: [email protected]
Cc: Jiri Slaby <[email protected]>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -128,6 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
config SERIAL_ATMEL
bool "AT91 on-chip serial port support"
depends on ARCH_AT91 || COMPILE_TEST
+ depends on COMMON_CLK
select SERIAL_CORE
select SERIAL_MCTRL_GPIO if GPIOLIB
select MFD_AT91_USART

2022-09-29 08:22:55

by Richard Genoud

Subject: Re: [PATCH -next] tty: serial: atmel: driver depends on COMMON_CLK

Hi,
Le 29/09/2022 à 07:48, Randy Dunlap a écrit :
> Since atmel_serial.c uses interfaces that are provided by
> the COMMON_CLK Kconfig symbol, the driver should depend on
> COMMON_CLK to prevent build errors.
>
> ld: drivers/tty/serial/atmel_serial.o: in function `atmel_serial_pm':
> atmel_serial.c:(.text+0x1553): undefined reference to `__clk_is_enabled'
> ld: drivers/tty/serial/atmel_serial.o: in function `atmel_set_termios':
> atmel_serial.c:(.text+0x1dfe): undefined reference to `__clk_is_enabled'
>
> Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Sergiu Moga <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Richard Genoud <[email protected]>
> Cc: [email protected]
> Cc: Jiri Slaby <[email protected]>

There's already a patch fixing this, acked by Nicolas :
https://lkml.org/lkml/2022/9/26/1587

> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -128,6 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
> config SERIAL_ATMEL
> bool "AT91 on-chip serial port support"
> depends on ARCH_AT91 || COMPILE_TEST
> + depends on COMMON_CLK
> select SERIAL_CORE
> select SERIAL_MCTRL_GPIO if GPIOLIB
> select MFD_AT91_USART

Thanks !

Regards,
Richard