2023-12-18 13:53:07

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 4.19 00/36] 4.19.303-rc1 review

This is the start of the stable review cycle for the 4.19.303 release.
There are 36 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 20 Dec 2023 13:50:31 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.303-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 4.19.303-rc1

Naveen N Rao <[email protected]>
powerpc/ftrace: Fix stack teardown in ftrace_no_trace

Naveen N Rao <[email protected]>
powerpc/ftrace: Create a dummy stackframe to fix stack unwind

Adrian Hunter <[email protected]>
mmc: block: Be sure to wait while busy in CQE error recovery

Steven Rostedt (Google) <[email protected]>
ring-buffer: Fix memory leak of free page

Florent Revest <[email protected]>
team: Fix use-after-free when an option instance allocation fails

James Houghton <[email protected]>
arm64: mm: Always make sw-dirty PTEs hw-dirty in pte_modify

Baokun Li <[email protected]>
ext4: prevent the normalized size from exceeding EXT_MAX_BLOCKS

Mark Rutland <[email protected]>
perf: Fix perf_event_validate_size() lockdep splat

Denis Benato <[email protected]>
HID: hid-asus: add const to read-only outgoing usb buffer

Lech Perczak <[email protected]>
net: usb: qmi_wwan: claim interface 4 for ZTE MF290

Linus Torvalds <[email protected]>
asm-generic: qspinlock: fix queued_spin_value_unlocked() implementation

Aoba K <[email protected]>
HID: multitouch: Add quirk for HONOR GLO-GXXX touchpad

Denis Benato <[email protected]>
HID: hid-asus: reset the backlight brightness level on resume

Oliver Neukum <[email protected]>
HID: add ALWAYS_POLL quirk for Apple kb

Andy Shevchenko <[email protected]>
platform/x86: intel_telemetry: Fix kernel doc descriptions

Coly Li <[email protected]>
bcache: avoid NULL checking to c->root in run_cache_set()

Coly Li <[email protected]>
bcache: add code comments for bch_btree_node_get() and __bch_btree_node_alloc()

Coly Li <[email protected]>
bcache: avoid oversize memory allocation by small stripe_size

Ming Lei <[email protected]>
blk-throttle: fix lockdep warning of "cgroup_mutex or RCU read lock required!"

Jens Axboe <[email protected]>
cred: switch to using atomic_long_t

Bjorn Helgaas <[email protected]>
Revert "PCI: acpiphp: Reassign resources on bridge if necessary"

Hyunwoo Kim <[email protected]>
appletalk: Fix Use-After-Free in atalk_ioctl

Andrew Halaney <[email protected]>
net: stmmac: Handle disabled MDIO busses from devicetree

Rasmus Villemoes <[email protected]>
net: stmmac: use dev_err_probe() for reporting mdio bus registration failure

Eric Dumazet <[email protected]>
net: prevent mss overflow in skb_segment()

Nikolay Kuratov <[email protected]>
vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space()

Yusong Gao <[email protected]>
sign-file: Fix incorrect return values check

Dong Chenchen <[email protected]>
net: Remove acked SYN flag from packet in the transmit queue correctly

Dinghao Liu <[email protected]>
qed: Fix a potential use-after-free in qed_cxt_tables_alloc

Hyunwoo Kim <[email protected]>
net/rose: Fix Use-After-Free in rose_ioctl

Hyunwoo Kim <[email protected]>
atm: Fix Use-After-Free in do_vcc_ioctl

Chengfeng Ye <[email protected]>
atm: solos-pci: Fix potential deadlock on &tx_queue_lock

Chengfeng Ye <[email protected]>
atm: solos-pci: Fix potential deadlock on &cli_queue_lock

Stefan Wahren <[email protected]>
qca_spi: Fix reset behavior

Stefan Wahren <[email protected]>
qca_debug: Fix ethtool -G iface tx behavior

Stefan Wahren <[email protected]>
qca_debug: Prevent crash on TX ring changes


-------------

Diffstat:

Makefile | 4 +-
arch/arm64/include/asm/pgtable.h | 6 +++
arch/powerpc/kernel/trace/ftrace_64_mprofile.S | 17 ++++--
block/blk-throttle.c | 2 +
drivers/atm/solos-pci.c | 8 +--
drivers/hid/hid-asus.c | 25 +++++++--
drivers/hid/hid-multitouch.c | 5 ++
drivers/hid/hid-quirks.c | 1 +
drivers/md/bcache/bcache.h | 1 +
drivers/md/bcache/btree.c | 7 +++
drivers/md/bcache/super.c | 4 +-
drivers/mmc/core/core.c | 2 +
drivers/mmc/core/mmc_ops.c | 5 +-
drivers/mmc/core/mmc_ops.h | 2 +
drivers/net/ethernet/qlogic/qed/qed_cxt.c | 1 +
drivers/net/ethernet/qualcomm/qca_debug.c | 17 +++---
drivers/net/ethernet/qualcomm/qca_spi.c | 20 ++++++-
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 ++-
drivers/net/team/team.c | 4 +-
drivers/net/usb/qmi_wwan.c | 1 +
drivers/pci/hotplug/acpiphp_glue.c | 9 ++--
drivers/platform/x86/intel_telemetry_core.c | 4 +-
fs/ext4/mballoc.c | 4 ++
include/asm-generic/qspinlock.h | 2 +-
include/linux/cred.h | 6 +--
kernel/cred.c | 66 +++++++++++------------
kernel/events/core.c | 10 ++++
kernel/trace/ring_buffer.c | 2 +
net/appletalk/ddp.c | 9 ++--
net/atm/ioctl.c | 7 ++-
net/core/skbuff.c | 3 +-
net/ipv4/tcp_output.c | 6 +++
net/rose/af_rose.c | 4 +-
net/vmw_vsock/virtio_transport_common.c | 2 +-
scripts/sign-file.c | 12 ++---
36 files changed, 197 insertions(+), 89 deletions(-)




2023-12-18 17:59:51

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

Hi!

> This is the start of the stable review cycle for the 4.19.303 release.
> There are 36 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (1.36 kB)
signature.asc (201.00 B)
Download all attachments

2023-12-19 00:05:52

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

On 12/18/23 06:51, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.303 release.
> There are 36 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 20 Dec 2023 13:50:31 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.303-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2023-12-19 05:28:03

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

Hello!

On 18/12/23 7:51 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.303 release.
> There are 36 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 20 Dec 2023 13:50:31 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.303-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

We see new warnings introduced in 32-bits system, with GCC 8, GCC 9, GCC 11, GCC 12, and Clang 17, on:
* arm
* i386
* arc
* mips
* powerpc
* s390
* sh
* sparc

It goes like this:

-----8<-----
In file included from /builds/linux/include/linux/list.h:9,
from /builds/linux/include/linux/module.h:9,
from /builds/linux/net/core/skbuff.c:41:
/builds/linux/net/core/skbuff.c: In function 'skb_segment':
/builds/linux/include/linux/kernel.h:847:43: warning: comparison of distinct pointer types lacks a cast
847 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
/builds/linux/include/linux/kernel.h:861:18: note: in expansion of macro '__typecheck'
861 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
/builds/linux/include/linux/kernel.h:871:31: note: in expansion of macro '__safe_cmp'
871 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
/builds/linux/include/linux/kernel.h:880:25: note: in expansion of macro '__careful_cmp'
880 | #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
/builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro 'min'
3630 | partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
| ^~~
----->8-----

Greetings!

Daniel Díaz
[email protected]


2023-12-19 05:54:50

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

Hello Greg,

On 19/12/23 10:57 am, Daniel Díaz wrote:
> Hello!
>

>
> -----8<-----
>   In file included from /builds/linux/include/linux/list.h:9,
>                    from /builds/linux/include/linux/module.h:9,
>                    from /builds/linux/net/core/skbuff.c:41:
>   /builds/linux/net/core/skbuff.c: In function 'skb_segment':
>   /builds/linux/include/linux/kernel.h:847:43: warning: comparison of
> distinct pointer types lacks a cast
>     847 |                 (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>         |                                           ^~
>   /builds/linux/include/linux/kernel.h:861:18: note: in expansion of
> macro '__typecheck'
>     861 |                 (__typecheck(x, y) && __no_side_effects(x, y))
>         |                  ^~~~~~~~~~~
>   /builds/linux/include/linux/kernel.h:871:31: note: in expansion of
> macro '__safe_cmp'
>     871 |         __builtin_choose_expr(__safe_cmp(x, y), \
>         |                               ^~~~~~~~~~
>   /builds/linux/include/linux/kernel.h:880:25: note: in expansion of
> macro '__careful_cmp'
>     880 | #define min(x, y)       __careful_cmp(x, y, <)
>         |                         ^~~~~~~~~~~~~
>   /builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro
> 'min'
>    3630 |                 partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
>         |                                ^~~
> ----->8-----
>

Note:

Caused by this commit:
98c6fb04f83b net: prevent mss overflow in skb_segment()

I don't see this commit being queued in other stable branches yet,
5.4.y, 5.10.y, 5.15.y, 6.1.y, 6.6.y but only 4.19.y

Thanks,
Harshit

> Greetings!
>
> Daniel Díaz
> [email protected]
>
>


2023-12-19 07:22:22

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

On Tue, Dec 19, 2023 at 11:23:48AM +0530, Harshit Mogalapalli wrote:
> Hello Greg,
>
> On 19/12/23 10:57 am, Daniel D?az wrote:
> > Hello!
> >
>
> >
> > -----8<-----
> > ? In file included from /builds/linux/include/linux/list.h:9,
> > ?????????????????? from /builds/linux/include/linux/module.h:9,
> > ?????????????????? from /builds/linux/net/core/skbuff.c:41:
> > ? /builds/linux/net/core/skbuff.c: In function 'skb_segment':
> > ? /builds/linux/include/linux/kernel.h:847:43: warning: comparison of
> > distinct pointer types lacks a cast
> > ??? 847 |???????????????? (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> > ??????? |?????????????????????????????????????????? ^~
> > ? /builds/linux/include/linux/kernel.h:861:18: note: in expansion of
> > macro '__typecheck'
> > ??? 861 |???????????????? (__typecheck(x, y) && __no_side_effects(x, y))
> > ??????? |????????????????? ^~~~~~~~~~~
> > ? /builds/linux/include/linux/kernel.h:871:31: note: in expansion of
> > macro '__safe_cmp'
> > ??? 871 |???????? __builtin_choose_expr(__safe_cmp(x, y), \
> > ??????? |?????????????????????????????? ^~~~~~~~~~
> > ? /builds/linux/include/linux/kernel.h:880:25: note: in expansion of
> > macro '__careful_cmp'
> > ??? 880 | #define min(x, y)?????? __careful_cmp(x, y, <)
> > ??????? |???????????????????????? ^~~~~~~~~~~~~
> > ? /builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro
> > 'min'
> > ?? 3630 |???????????????? partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
> > ??????? |??????????????????????????????? ^~~
> > ----->8-----
> >
>
> Note:
>
> Caused by this commit:
> 98c6fb04f83b net: prevent mss overflow in skb_segment()
>
> I don't see this commit being queued in other stable branches yet, 5.4.y,
> 5.10.y, 5.15.y, 6.1.y, 6.6.y but only 4.19.y

Odd, Sasha, did something happen with your scripts? I'll drop this from
4.19.y now, but it looks like it needs to be added to all branches.
Maybe because we don't really notice new build warnings on 4.19.y that
easily (due to so many of them), this got left in :(

thanks,

greg k-h

2023-12-19 11:31:22

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

On Mon, 18 Dec 2023 14:51:10 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.303 release.
> There are 36 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 20 Dec 2023 13:50:31 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.303-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v4.19:
10 builds: 10 pass, 0 fail
20 boots: 20 pass, 0 fail
37 tests: 37 pass, 0 fail

Linux version: 4.19.303-rc1-gc6ac8872cc6c
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon