2023-04-09 03:02:19

by Axel Lin

Subject: [PATCH] regulator: sm5703: Fix missing n_voltages for fixed regulators

Set n_voltages = 1 for fixed regulators.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/sm5703-regulator.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/sm5703-regulator.c b/drivers/regulator/sm5703-regulator.c
index 38e66df378a5..702461cf075e 100644
--- a/drivers/regulator/sm5703-regulator.c
+++ b/drivers/regulator/sm5703-regulator.c
@@ -42,6 +42,7 @@ static const int sm5703_buck_voltagemap[] = {
.type = REGULATOR_VOLTAGE, \
.id = SM5703_USBLDO ## _id, \
.ops = &sm5703_regulator_ops_fixed, \
+ .n_voltages = 1, \
.fixed_uV = SM5703_USBLDO_MICROVOLT, \
.enable_reg = SM5703_REG_USBLDO12, \
.enable_mask = SM5703_REG_EN_USBLDO ##_id, \
@@ -56,6 +57,7 @@ static const int sm5703_buck_voltagemap[] = {
.type = REGULATOR_VOLTAGE, \
.id = SM5703_VBUS, \
.ops = &sm5703_regulator_ops_fixed, \
+ .n_voltages = 1, \
.fixed_uV = SM5703_VBUS_MICROVOLT, \
.enable_reg = SM5703_REG_CNTL, \
.enable_mask = SM5703_OPERATION_MODE_MASK, \
--
2.34.1

2023-04-09 13:32:07

by Markuss Broks

Subject: Re: [PATCH] regulator: sm5703: Fix missing n_voltages for fixed regulators

Looks good.

Reviewed-by: Markuss Broks <[email protected]>

On 4/9/23 05:55, Axel Lin wrote:
> Set n_voltages = 1 for fixed regulators.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/sm5703-regulator.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/regulator/sm5703-regulator.c b/drivers/regulator/sm5703-regulator.c
> index 38e66df378a5..702461cf075e 100644
> --- a/drivers/regulator/sm5703-regulator.c
> +++ b/drivers/regulator/sm5703-regulator.c
> @@ -42,6 +42,7 @@ static const int sm5703_buck_voltagemap[] = {
> .type = REGULATOR_VOLTAGE, \
> .id = SM5703_USBLDO ## _id, \
> .ops = &sm5703_regulator_ops_fixed, \
> + .n_voltages = 1, \
> .fixed_uV = SM5703_USBLDO_MICROVOLT, \
> .enable_reg = SM5703_REG_USBLDO12, \
> .enable_mask = SM5703_REG_EN_USBLDO ##_id, \
> @@ -56,6 +57,7 @@ static const int sm5703_buck_voltagemap[] = {
> .type = REGULATOR_VOLTAGE, \
> .id = SM5703_VBUS, \
> .ops = &sm5703_regulator_ops_fixed, \
> + .n_voltages = 1, \
> .fixed_uV = SM5703_VBUS_MICROVOLT, \
> .enable_reg = SM5703_REG_CNTL, \
> .enable_mask = SM5703_OPERATION_MODE_MASK, \

2023-04-11 13:58:04

by Mark Brown

Subject: Re: [PATCH] regulator: sm5703: Fix missing n_voltages for fixed regulators

On Sun, 09 Apr 2023 10:55:29 +0800, Axel Lin wrote:
> Set n_voltages = 1 for fixed regulators.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: sm5703: Fix missing n_voltages for fixed regulators
commit: 7c7504067c709905fc188c61ac3072d6022d1209

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark