2010-07-08 01:46:11

by Axel Lin

Subject: [PATCH] acerhdf: make needlessly global symbols static

The following symbols are needlessly defined global:

thz_dev
cl_dev
acerhdf_dev
acerhdf_dev_ops
acerhdf_cooling_ops

This patch makes the symbols static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/platform/x86/acerhdf.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 7b2384d..5caaaf0 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
static char force_bios[16];
static char force_product[16];
static unsigned int prev_interval;
-struct thermal_zone_device *thz_dev;
-struct thermal_cooling_device *cl_dev;
-struct platform_device *acerhdf_dev;
+static struct thermal_zone_device *thz_dev;
+static struct thermal_cooling_device *cl_dev;
+static struct platform_device *acerhdf_dev;

module_param(kernelmode, uint, 0);
MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");
@@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
}

/* bind callback functions to thermalzone */
-struct thermal_zone_device_ops acerhdf_dev_ops = {
+static struct thermal_zone_device_ops acerhdf_dev_ops = {
.bind = acerhdf_bind,
.unbind = acerhdf_unbind,
.get_temp = acerhdf_get_ec_temp,
@@ -449,7 +449,7 @@ err_out:
}

/* bind fan callbacks to fan device */
-struct thermal_cooling_device_ops acerhdf_cooling_ops = {
+static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
.get_max_state = acerhdf_get_max_state,
.get_cur_state = acerhdf_get_cur_state,
.set_cur_state = acerhdf_set_cur_state,
--
1.5.4.3

2010-07-08 09:08:44

by Borislav Petkov

Subject: Re: [PATCH] acerhdf: make needlessly global symbols static

From: Axel Lin <[email protected]>
Date: Thu, Jul 08, 2010 at 09:46:20AM +0800

> The following symbols are needlessly defined global:
>
> thz_dev
> cl_dev
> acerhdf_dev
> acerhdf_dev_ops
> acerhdf_cooling_ops
>
> This patch makes the symbols static.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Borislav Petkov <[email protected]>

> ---
> drivers/platform/x86/acerhdf.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 7b2384d..5caaaf0 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
> static char force_bios[16];
> static char force_product[16];
> static unsigned int prev_interval;
> -struct thermal_zone_device *thz_dev;
> -struct thermal_cooling_device *cl_dev;
> -struct platform_device *acerhdf_dev;
> +static struct thermal_zone_device *thz_dev;
> +static struct thermal_cooling_device *cl_dev;
> +static struct platform_device *acerhdf_dev;
>
> module_param(kernelmode, uint, 0);
> MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");
> @@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
> }
>
> /* bind callback functions to thermalzone */
> -struct thermal_zone_device_ops acerhdf_dev_ops = {
> +static struct thermal_zone_device_ops acerhdf_dev_ops = {
> .bind = acerhdf_bind,
> .unbind = acerhdf_unbind,
> .get_temp = acerhdf_get_ec_temp,
> @@ -449,7 +449,7 @@ err_out:
> }
>
> /* bind fan callbacks to fan device */
> -struct thermal_cooling_device_ops acerhdf_cooling_ops = {
> +static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
> .get_max_state = acerhdf_get_max_state,
> .get_cur_state = acerhdf_get_cur_state,
> .set_cur_state = acerhdf_set_cur_state,
> --
> 1.5.4.3
>
>
>

--
Regards/Gruss,
Boris.

2010-07-10 17:48:08

by Peter Kästle

Subject: Re: [PATCH] acerhdf: make needlessly global symbols static

Borislav Petkov writes:

> From: Axel Lin <[email protected]>
> Date: Thu, Jul 08, 2010 at 09:46:20AM +0800
>
>> The following symbols are needlessly defined global:
>>
>> thz_dev
>> cl_dev
>> acerhdf_dev
>> acerhdf_dev_ops
>> acerhdf_cooling_ops
>>
>> This patch makes the symbols static.
>>
>> Signed-off-by: Axel Lin <[email protected]>
>
> Acked-by: Borislav Petkov <[email protected]>

Acked-by: Peter Feuerer <[email protected]>

>
>> ---
>> drivers/platform/x86/acerhdf.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
>> index 7b2384d..5caaaf0 100644
>> --- a/drivers/platform/x86/acerhdf.c
>> +++ b/drivers/platform/x86/acerhdf.c
>> @@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
>> static char force_bios[16];
>> static char force_product[16];
>> static unsigned int prev_interval;
>> -struct thermal_zone_device *thz_dev;
>> -struct thermal_cooling_device *cl_dev;
>> -struct platform_device *acerhdf_dev;
>> +static struct thermal_zone_device *thz_dev;
>> +static struct thermal_cooling_device *cl_dev;
>> +static struct platform_device *acerhdf_dev;
>>
>> module_param(kernelmode, uint, 0);
>> MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");
>> @@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
>> }
>>
>> /* bind callback functions to thermalzone */
>> -struct thermal_zone_device_ops acerhdf_dev_ops = {
>> +static struct thermal_zone_device_ops acerhdf_dev_ops = {
>> .bind = acerhdf_bind,
>> .unbind = acerhdf_unbind,
>> .get_temp = acerhdf_get_ec_temp,
>> @@ -449,7 +449,7 @@ err_out:
>> }
>>
>> /* bind fan callbacks to fan device */
>> -struct thermal_cooling_device_ops acerhdf_cooling_ops = {
>> +static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
>> .get_max_state = acerhdf_get_max_state,
>> .get_cur_state = acerhdf_get_cur_state,
>> .set_cur_state = acerhdf_set_cur_state,
>> --
>> 1.5.4.3
>>
>>
>>

thanks and kind regards,
--peter;