2023-12-04 21:52:59

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 0/2] platform/x86: Convert to platform remove callback returning void (part II)

Hello,

back when I sent a series to convert all platform drivers below
drivers/platform to use .remove_new()[1] I missed the two drivers
converted here.

The two patches have no dependency, so each can be picked individually
if needed by the driver maintainers. (But I won't say no if Hans picks
up both patches together :-)

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.

Best regards
Uwe

[1] https://lore.kernel.org/r/[email protected]


Uwe Kleine-König (2):
platform/x86: asus-wmi: Convert to platform remove callback returning
void
platform/x86: hp-wmi: Convert to platform remove callback returning
void

drivers/platform/x86/asus-wmi.c | 5 ++---
drivers/platform/x86/hp/hp-wmi.c | 6 ++----
2 files changed, 4 insertions(+), 7 deletions(-)

base-commit: 629a3b49f3f957e975253c54846090b8d5ed2e9b
--
2.42.0


2023-12-11 10:04:37

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH 0/2] platform/x86: Convert to platform remove callback returning void (part II)

Hi,

On 12/4/23 22:52, Uwe Kleine-König wrote:
> Hello,
>
> back when I sent a series to convert all platform drivers below
> drivers/platform to use .remove_new()[1] I missed the two drivers
> converted here.
>
> The two patches have no dependency, so each can be picked individually
> if needed by the driver maintainers. (But I won't say no if Hans picks
> up both patches together :-)

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans





> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> Best regards
> Uwe
>
> [1] https://lore.kernel.org/r/[email protected]
>
>
> Uwe Kleine-König (2):
> platform/x86: asus-wmi: Convert to platform remove callback returning
> void
> platform/x86: hp-wmi: Convert to platform remove callback returning
> void
>
> drivers/platform/x86/asus-wmi.c | 5 ++---
> drivers/platform/x86/hp/hp-wmi.c | 6 ++----
> 2 files changed, 4 insertions(+), 7 deletions(-)
>
> base-commit: 629a3b49f3f957e975253c54846090b8d5ed2e9b