2020-10-26 12:03:44

by Michal Kubecek

[permalink] [raw]
Subject: [Regression] s390x build broken with 5.10-rc1 (bisected)

Hello,

5.10-rc1 builds on s390x fail with

make -f ./scripts/Makefile.build obj=arch/s390/boot arch/s390/boot/bzImage
make -f ./scripts/Makefile.modpost
make -f ./scripts/Makefile.modfinal
make -f ./scripts/Makefile.build obj=arch/s390/boot/compressed arch/s390/boot/compressed/vmlinux
s1=`s390x-suse-linux-objdump -t -j ".boot.data" "vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.data\s\+//p" | sha256sum`; s2=`s390x-suse-linux-objdump -t -j ".boot.data" "arch/s390/boot/compressed/vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.data\s\+//p" | sha256sum`; if [ "$s1" != "$s2" ]; then echo "error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux" >&2; exit 1; fi; touch arch/s390/boot/section_cmp.boot.data
s1=`s390x-suse-linux-objdump -t -j ".boot.preserved.data" "vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.preserved.data\s\+//p" | sha256sum`; s2=`s390x-suse-linux-objdump -t -j ".boot.preserved.data" "arch/s390/boot/compressed/vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.preserved.data\s\+//p" | sha256sum`; if [ "$s1" != "$s2" ]; then echo "error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux" >&2; exit 1; fi; touch arch/s390/boot/section_cmp.boot.preserved.data
error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
make[1]: *** [arch/s390/boot/Makefile:65: arch/s390/boot/section_cmp.boot.data] Error 1
make[1]: *** Waiting for unfinished jobs....
error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
make[1]: *** [arch/s390/boot/Makefile:65: arch/s390/boot/section_cmp.boot.preserved.data] Error 1
make: *** [arch/s390/Makefile:153: bzImage] Error 2
make: *** Waiting for unfinished jobs....

Bisect identified commit 33def8498fdd ("treewide: Convert macro and uses
of __section(foo) to __section("foo")"), i.e. the very last commit
before tagging v5.10-rc1.

I can reproduce this with e.g. defconfig and both native s390x build and
build on x86_64 using cross compiler. I used gcc 10.2.1 and binutils 2.34.

Michal


2020-10-26 13:35:54

by Vasily Gorbik

[permalink] [raw]
Subject: Re: [Regression] s390x build broken with 5.10-rc1 (bisected)

On Mon, Oct 26, 2020 at 11:48:11AM +0100, Michal Kubecek wrote:
> Hello,
>
> 5.10-rc1 builds on s390x fail with
>
> make -f ./scripts/Makefile.build obj=arch/s390/boot arch/s390/boot/bzImage
> make -f ./scripts/Makefile.modpost
> make -f ./scripts/Makefile.modfinal
> make -f ./scripts/Makefile.build obj=arch/s390/boot/compressed arch/s390/boot/compressed/vmlinux
> s1=`s390x-suse-linux-objdump -t -j ".boot.data" "vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.data\s\+//p" | sha256sum`; s2=`s390x-suse-linux-objdump -t -j ".boot.data" "arch/s390/boot/compressed/vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.data\s\+//p" | sha256sum`; if [ "$s1" != "$s2" ]; then echo "error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux" >&2; exit 1; fi; touch arch/s390/boot/section_cmp.boot.data
> s1=`s390x-suse-linux-objdump -t -j ".boot.preserved.data" "vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.preserved.data\s\+//p" | sha256sum`; s2=`s390x-suse-linux-objdump -t -j ".boot.preserved.data" "arch/s390/boot/compressed/vmlinux" | sort | sed -n "/0000000000000000/! s/.*\s.boot.preserved.data\s\+//p" | sha256sum`; if [ "$s1" != "$s2" ]; then echo "error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux" >&2; exit 1; fi; touch arch/s390/boot/section_cmp.boot.preserved.data
> error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
> make[1]: *** [arch/s390/boot/Makefile:65: arch/s390/boot/section_cmp.boot.data] Error 1
> make[1]: *** Waiting for unfinished jobs....
> error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
> make[1]: *** [arch/s390/boot/Makefile:65: arch/s390/boot/section_cmp.boot.preserved.data] Error 1
> make: *** [arch/s390/Makefile:153: bzImage] Error 2
> make: *** Waiting for unfinished jobs....
>
> Bisect identified commit 33def8498fdd ("treewide: Convert macro and uses
> of __section(foo) to __section("foo")"), i.e. the very last commit
> before tagging v5.10-rc1.
>
> I can reproduce this with e.g. defconfig and both native s390x build and
> build on x86_64 using cross compiler. I used gcc 10.2.1 and binutils 2.34.
>
> Michal

Hello Michal,

I've already fixed that. The fix will appear shortly on s390/fixes
Thank you for reporting!

Vasily Gorbik (1):
s390: correct __bootdata / __bootdata_preserved macros

arch/s390/include/asm/sections.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
2.25.4