2023-07-04 13:20:35

by Geert Uytterhoeven

[permalink] [raw]

Subject: [PATCH] mfd: rk808: Make MFD_RK8XX tristate

---

There is no reason for MFD_RK8XX to be bool, all drivers that depend on
it, or that select it, are tristate.

Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6f5b259a6d6a0b9d..f6b519eaaa710e71 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1197,7 +1197,7 @@ config MFD_RC5T583
different functionality of the device.

config MFD_RK8XX
- bool
+ tristate
select MFD_CORE

config MFD_RK8XX_I2C
--
2.34.1

2023-07-05 17:46:45

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] mfd: rk808: Make MFD_RK8XX tristate

---

Hi,

On Tue, Jul 04, 2023 at 03:07:48PM +0200, Geert Uytterhoeven wrote:
> There is no reason for MFD_RK8XX to be bool, all drivers that depend on
> it, or that select it, are tristate.
>
> Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Thanks, LGTM.

Reviewed-by: Sebastian Reichel <[email protected]>
Tested-by: Sebastian Reichel <[email protected]>

-- Sebastian

> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6f5b259a6d6a0b9d..f6b519eaaa710e71 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1197,7 +1197,7 @@ config MFD_RC5T583
> different functionality of the device.
>
> config MFD_RK8XX
> - bool
> + tristate
> select MFD_CORE
>
> config MFD_RK8XX_I2C
> --
> 2.34.1
>

---

Attachments:

(No filename) (963.00 B)
signature.asc (849.00 B)
Download all attachments

2023-07-13 14:14:19

by Lee Jones

[permalink] [raw]

Subject: Re: [PATCH] mfd: rk808: Make MFD_RK8XX tristate

---

On Tue, 04 Jul 2023, Geert Uytterhoeven wrote:

> There is no reason for MFD_RK8XX to be bool, all drivers that depend on
> it, or that select it, are tristate.
>
> Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]