2023-09-21 21:38:10

by Abel Vesa

Subject: [PATCH] clk: imx: Select MXC_CLK for CLK_IMX8QXP

If the i.MX8QXP clock provider is built-in but the MXC_CLK is
built as module, build fails:

aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'

Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.

Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Closes: https://lore.kernel.org/all/[email protected]/
Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: Abel Vesa <[email protected]>
---
drivers/clk/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index f6b82e0b9703..db3bca5f4ec9 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -96,6 +96,7 @@ config CLK_IMX8QXP
depends on (ARCH_MXC && ARM64) || COMPILE_TEST
depends on IMX_SCU && HAVE_ARM_SMCCC
select MXC_CLK_SCU
+ select MXC_CLK
help
Build the driver for IMX8QXP SCU based clocks.

--
2.34.1

2023-09-22 06:18:02

by Randy Dunlap

Subject: Re: [PATCH] clk: imx: Select MXC_CLK for CLK_IMX8QXP

On 9/21/23 02:36, Abel Vesa wrote:
> If the i.MX8QXP clock provider is built-in but the MXC_CLK is
> built as module, build fails:
>
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'
>
> Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.
>
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Closes: https://lore.kernel.org/all/[email protected]/
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Abel Vesa <[email protected]>

Acked-by: Randy Dunlap <[email protected]>
Tested-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/clk/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index f6b82e0b9703..db3bca5f4ec9 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -96,6 +96,7 @@ config CLK_IMX8QXP
> depends on (ARCH_MXC && ARM64) || COMPILE_TEST
> depends on IMX_SCU && HAVE_ARM_SMCCC
> select MXC_CLK_SCU
> + select MXC_CLK
> help
> Build the driver for IMX8QXP SCU based clocks.
>

--
~Randy