In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <[email protected]>
---
drivers/block/skd_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index c479235862e5..51569c199a6c 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2694,7 +2694,6 @@ static int skd_cons_skmsg(struct skd_device *skdev)
(FIT_QCMD_ALIGN - 1),
"not aligned: msg_buf %p mb_dma_address %pad\n",
skmsg->msg_buf, &skmsg->mb_dma_address);
- memset(skmsg->msg_buf, 0, SKD_N_FITMSG_BYTES);
}
err_out:
--
2.11.0
Looks good.
Reviewed-by: Chaitanya Kulkarni <[email protected]>
On 06/27/2019 10:35 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <[email protected]>
> ---
> drivers/block/skd_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index c479235862e5..51569c199a6c 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -2694,7 +2694,6 @@ static int skd_cons_skmsg(struct skd_device *skdev)
> (FIT_QCMD_ALIGN - 1),
> "not aligned: msg_buf %p mb_dma_address %pad\n",
> skmsg->msg_buf, &skmsg->mb_dma_address);
> - memset(skmsg->msg_buf, 0, SKD_N_FITMSG_BYTES);
> }
>
> err_out:
>
On 6/27/19 11:35 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
Applied, thanks.
--
Jens Axboe