2017-11-06 06:35:39

by Vasily Averin

[permalink] [raw]
Subject: Re: [PATCH] lost path_put in perf_fill_ns_link_info

Dear Hari,
I did not found where your patch decreases mnt counter,
it seems for me you have lost path_put in perf_fill_ns_link_info().

Thank you,
Vasily Averin

On 2017-11-06 09:22, Vasily Averin wrote:
> Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info")
> Signed-off-by: Vasily Averin <[email protected]>
> ---
> kernel/events/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 10cdb9c..ab5ac84 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6756,6 +6756,7 @@ static void perf_fill_ns_link_info(struct perf_ns_link_info *ns_link_info,
> ns_inode = ns_path.dentry->d_inode;
> ns_link_info->dev = new_encode_dev(ns_inode->i_sb->s_dev);
> ns_link_info->ino = ns_inode->i_ino;
> + path_put(&ns_path);
> }
> }
>
>

From 1583296720926435526@xxx Mon Nov 06 06:23:37 +0000 2017
X-GM-THRID: 1583296720926435526
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread