2023-10-10 11:39:54

by Tiwei Bie

Subject: [PATCH] erofs: fix inode metadata space layout description in documentation

Xattrs, extents, data inline are _placed after_, not _followed by_ the
corresponding inode. This patch fixes it.

Fixes: fdb0536469cb ("staging: erofs: add document")
Signed-off-by: Tiwei Bie <[email protected]>
---
Documentation/filesystems/erofs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
index f200d7874495..57c6ae23b3fc 100644
--- a/Documentation/filesystems/erofs.rst
+++ b/Documentation/filesystems/erofs.rst
@@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
| |
|__________________| 64 bytes

- Xattrs, extents, data inline are followed by the corresponding inode with
+ Xattrs, extents, data inline are placed after the corresponding inode with
proper alignment, and they could be optional for different data mappings.
_currently_ total 5 data layouts are supported:

--
2.34.1

2023-10-10 12:44:44

by Jingbo Xu

Subject: Re: [PATCH] erofs: fix inode metadata space layout description in documentation

On 10/10/23 7:39 PM, Tiwei Bie wrote:
> Xattrs, extents, data inline are _placed after_, not _followed by_ the
> corresponding inode. This patch fixes it.
>
> Fixes: fdb0536469cb ("staging: erofs: add document")
> Signed-off-by: Tiwei Bie <[email protected]>
> ---
> Documentation/filesystems/erofs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index f200d7874495..57c6ae23b3fc 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
> | |
> |__________________| 64 bytes
>
> - Xattrs, extents, data inline are followed by the corresponding inode with
> + Xattrs, extents, data inline are placed after the corresponding inode with
> proper alignment, and they could be optional for different data mappings.
> _currently_ total 5 data layouts are supported:
>

Thanks for catching it!

Reviewed-by: Jingbo Xu <[email protected]>

--
Thanks,
Jingbo

2023-10-10 13:06:41

by Gao Xiang

Subject: Re: [PATCH] erofs: fix inode metadata space layout description in documentation

Hi Tiwei,

On 2023/10/10 19:39, Tiwei Bie via Linux-erofs wrote:
> Xattrs, extents, data inline are _placed after_, not _followed by_ the
> corresponding inode. This patch fixes it

Thanks for the patch and sorry about my terrible English...

>
> Fixes: fdb0536469cb ("staging: erofs: add document")

I'm not sure if it's necessary to tag document fixes anyway
since docs.kernel.org already uses the latest version and
`.rst` format is adapted much later..

I will drop this tag for the next merge window if not urgent.

> Signed-off-by: Tiwei Bie <[email protected]>

Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

> ---
> Documentation/filesystems/erofs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index f200d7874495..57c6ae23b3fc 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
> | |
> |__________________| 64 bytes
>
> - Xattrs, extents, data inline are followed by the corresponding inode with
> + Xattrs, extents, data inline are placed after the corresponding inode with
> proper alignment, and they could be optional for different data mappings.
> _currently_ total 5 data layouts are supported:
>

2023-10-10 13:44:05

by Tiwei Bie

Subject: Re: [PATCH] erofs: fix inode metadata space layout description in documentation

On 10/10/23 9:06 PM, Gao Xiang wrote:
>> Fixes: fdb0536469cb ("staging: erofs: add document")
>
> I'm not sure if it's necessary to tag document fixes anyway
> since docs.kernel.org already uses the latest version and
> `.rst` format is adapted much later..
>
> I will drop this tag for the next merge window if not urgent.

Thanks! This patch is not urgent. :)

Regards,
Tiwei

2023-10-12 01:10:55

by Chao Yu

Subject: Re: [PATCH] erofs: fix inode metadata space layout description in documentation

On 2023/10/10 21:06, Gao Xiang wrote:
>> Signed-off-by: Tiwei Bie <[email protected]>
>
> Reviewed-by: Gao Xiang <[email protected]>

Looks fine to me for the version in dev-test branch.

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-10-12 02:01:34

by Gao Xiang

Subject: Re: [PATCH] erofs: fix inode metadata space layout description in documentation

Hi Chao,

On 2023/10/12 09:10, Chao Yu wrote:
> On 2023/10/10 21:06, Gao Xiang wrote:
>>> Signed-off-by: Tiwei Bie <[email protected]>
>>
>> Reviewed-by: Gao Xiang <[email protected]>
>
> Looks fine to me for the version in dev-test branch.
>
> Reviewed-by: Chao Yu <[email protected]>

Yeah, thanks! I will add the tag when applying to -next.

Thanks,
Gao Xiang

>
> Thanks,