Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
However the dtschema expects "clocks" property if "assigned-clocks" are
used. Add reference to input clock, the parent used in
"assigned-clock-parents" to silence the dtschema warnings:
arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v2:
1. Use XUSBXTI as real input clock.
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index ca3c78e0966c..4a9f9881f10f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -120,6 +120,7 @@
};
&clock {
+ clocks = <&clock CLK_XUSBXTI>;
assigned-clocks = <&clock CLK_FOUT_EPLL>;
assigned-clock-rates = <45158401>;
};
--
2.17.1
On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote:
> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
>
> However the dtschema expects "clocks" property if "assigned-clocks" are
> used. Add reference to input clock, the parent used in
> "assigned-clock-parents" to silence the dtschema warnings:
>
> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
>
Applied.
Best regards,
Krzysztof
Hi Krzysztof,
On 11.09.2020 16:54, Krzysztof Kozlowski wrote:
> On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote:
>> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
>> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
>>
>> However the dtschema expects "clocks" property if "assigned-clocks" are
>> used. Add reference to input clock, the parent used in
>> "assigned-clock-parents" to silence the dtschema warnings:
>>
>> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
>>
> Applied.
This patch breaks operation of clocks on Odroid X2/U3:
# dmesg | grep clk
[ 0.000000] exynos_clkout_init: failed to register clkout clock
[ 0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll =
800000000
sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk =
1000000000
[ 2.569484] usb3503 0-0008: unable to request refclk (-517)
[ 2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2
(50000000 Hz)
[ 3.373850] usb3503 0-0008: unable to request refclk (-517)
[ 3.542777] usb3503 0-0008: unable to request refclk (-517)
[ 3.544005] usb3503 0-0008: unable to request refclk (-517)
[ 3.559223] usb3503 0-0008: unable to request refclk (-517)
Please revert or drop if possible.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On Mon, 21 Sep 2020 at 11:42, Marek Szyprowski <[email protected]> wrote:
>
> Hi Krzysztof,
>
> On 11.09.2020 16:54, Krzysztof Kozlowski wrote:
> > On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote:
> >> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
> >> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
> >>
> >> However the dtschema expects "clocks" property if "assigned-clocks" are
> >> used. Add reference to input clock, the parent used in
> >> "assigned-clock-parents" to silence the dtschema warnings:
> >>
> >> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
> >>
> > Applied.
>
> This patch breaks operation of clocks on Odroid X2/U3:
>
> # dmesg | grep clk
> [ 0.000000] exynos_clkout_init: failed to register clkout clock
> [ 0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll =
> 800000000
> sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk =
> 1000000000
> [ 2.569484] usb3503 0-0008: unable to request refclk (-517)
> [ 2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2
> (50000000 Hz)
> [ 3.373850] usb3503 0-0008: unable to request refclk (-517)
> [ 3.542777] usb3503 0-0008: unable to request refclk (-517)
> [ 3.544005] usb3503 0-0008: unable to request refclk (-517)
> [ 3.559223] usb3503 0-0008: unable to request refclk (-517)
>
> Please revert or drop if possible.
Crap, thanks for noticing. I tested only Odroid X where the usb3503
came up. I'll try to fix it or revert.
Best regards,
Krzysztof
On Mon, Sep 21, 2020 at 11:42:40AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 11.09.2020 16:54, Krzysztof Kozlowski wrote:
> > On Sun, Sep 06, 2020 at 04:21:45PM +0200, Krzysztof Kozlowski wrote:
> >> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
> >> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
> >>
> >> However the dtschema expects "clocks" property if "assigned-clocks" are
> >> used. Add reference to input clock, the parent used in
> >> "assigned-clock-parents" to silence the dtschema warnings:
> >>
> >> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
> >>
> > Applied.
>
> This patch breaks operation of clocks on Odroid X2/U3:
>
> # dmesg | grep clk
> [ 0.000000] exynos_clkout_init: failed to register clkout clock
> [ 0.000000] Exynos4x12 clocks: sclk_apll = 1000000000, sclk_mpll =
> 800000000
> sclk_epll = 45158401, sclk_vpll = 350000000, arm_clk =
> 1000000000
> [ 2.569484] usb3503 0-0008: unable to request refclk (-517)
> [ 2.848718] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2
> (50000000 Hz)
> [ 3.373850] usb3503 0-0008: unable to request refclk (-517)
> [ 3.542777] usb3503 0-0008: unable to request refclk (-517)
> [ 3.544005] usb3503 0-0008: unable to request refclk (-517)
> [ 3.559223] usb3503 0-0008: unable to request refclk (-517)
>
> Please revert or drop if possible.
I re-applied this one (it was once reverted), as clkout was converted to
proper driver. My Odroid U3 boots fine now with this patch.
Best regards,
Krzysztof