2022-07-20 19:46:22

by Melissa Wen

Subject: [PATCH 2/5] drm/amd/display: remove useless FPU protection wrapper from dcn31_resource file

Many lines of code in dcn31_resource_construct are wrapped by DC_FP
macro to protect FPU operations; however, there is no FPU in this
region. Therefore, just remove the wrapper for clarity.

Signed-off-by: Melissa Wen <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
index 929b712cbada..6d25fcf865bf 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
@@ -1863,8 +1863,6 @@ static bool dcn31_resource_construct(
struct dc_context *ctx = dc->ctx;
struct irq_service_init_data init_data;

- DC_FP_START();
-
ctx->dc_bios->regs = &bios_regs;

pool->base.res_cap = &res_cap_dcn31;
@@ -2175,13 +2173,9 @@ static bool dcn31_resource_construct(

dc->dcn_ip->max_num_dpp = dcn3_1_ip.max_num_dpp;

- DC_FP_END();
-
return true;

create_fail:
-
- DC_FP_END();
dcn31_resource_destruct(pool);

return false;
--
2.35.1

2022-07-21 19:36:24

by Rodrigo Siqueira Jordao

Subject: Re: [PATCH 2/5] drm/amd/display: remove useless FPU protection wrapper from dcn31_resource file

On 2022-07-20 15:32, Melissa Wen wrote:
> Many lines of code in dcn31_resource_construct are wrapped by DC_FP
> macro to protect FPU operations; however, there is no FPU in this
> region. Therefore, just remove the wrapper for clarity.
>
> Signed-off-by: Melissa Wen <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> index 929b712cbada..6d25fcf865bf 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> @@ -1863,8 +1863,6 @@ static bool dcn31_resource_construct(
> struct dc_context *ctx = dc->ctx;
> struct irq_service_init_data init_data;
>
> - DC_FP_START();
> -
> ctx->dc_bios->regs = &bios_regs;
>
> pool->base.res_cap = &res_cap_dcn31;
> @@ -2175,13 +2173,9 @@ static bool dcn31_resource_construct(
>
> dc->dcn_ip->max_num_dpp = dcn3_1_ip.max_num_dpp;
>
> - DC_FP_END();
> -
> return true;
>
> create_fail:
> -
> - DC_FP_END();
> dcn31_resource_destruct(pool);
>
> return false;

Very nice catch!

Reviewed-by: Rodrigo Siqueira <[email protected]>