2017-06-07 10:57:36

by Daniel Thompson

Subject: Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm

On 21/05/17 23:09, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <[email protected]>

Acked-by: Daniel Thompson <[email protected]>

> ---
> arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
> drivers/video/backlight/adp8860_bl.c | 2 +-
> include/linux/{i2c => platform_data}/adp8860.h | 0
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename include/linux/{i2c => platform_data}/adp8860.h (100%)
>
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 24985e658c19cd..7db90c72bd8ddc 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data adp8870_pdata = {
> #endif
>
> #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
> -#include <linux/i2c/adp8860.h>
> +#include <linux/platform_data/adp8860.h>
> static struct led_info adp8860_leds[] = {
> {
> .name = "adp8860-led7",
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 510e559c060e59..e7315bf14d6015 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -18,7 +18,7 @@
> #include <linux/slab.h>
> #include <linux/workqueue.h>
>
> -#include <linux/i2c/adp8860.h>
> +#include <linux/platform_data/adp8860.h>
> #define ADP8860_EXT_FEATURES
> #define ADP8860_USE_LEDS
>
> diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
> similarity index 100%
> rename from include/linux/i2c/adp8860.h
> rename to include/linux/platform_data/adp8860.h
>

2017-06-07 12:09:10

by Hennerich, Michael

Subject: Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm

On 07.06.2017 12:57, Daniel Thompson wrote:
> On 21/05/17 23:09, Wolfram Sang wrote:
>> include/linux/i2c is not for client devices. Move the header file to a
>> more appropriate location.
>>
>> Signed-off-by: Wolfram Sang <[email protected]>
>
> Acked-by: Daniel Thompson <[email protected]>

Acked-by: Michael Hennerich <[email protected]>

>
>> ---
>> arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
>> drivers/video/backlight/adp8860_bl.c | 2 +-
>> include/linux/{i2c => platform_data}/adp8860.h | 0
>> 3 files changed, 2 insertions(+), 2 deletions(-)
>> rename include/linux/{i2c => platform_data}/adp8860.h (100%)
>>
>> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c
>> b/arch/blackfin/mach-bf537/boards/stamp.c
>> index 24985e658c19cd..7db90c72bd8ddc 100644
>> --- a/arch/blackfin/mach-bf537/boards/stamp.c
>> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
>> @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data
>> adp8870_pdata = {
>> #endif
>> #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
>> -#include <linux/i2c/adp8860.h>
>> +#include <linux/platform_data/adp8860.h>
>> static struct led_info adp8860_leds[] = {
>> {
>> .name = "adp8860-led7",
>> diff --git a/drivers/video/backlight/adp8860_bl.c
>> b/drivers/video/backlight/adp8860_bl.c
>> index 510e559c060e59..e7315bf14d6015 100644
>> --- a/drivers/video/backlight/adp8860_bl.c
>> +++ b/drivers/video/backlight/adp8860_bl.c
>> @@ -18,7 +18,7 @@
>> #include <linux/slab.h>
>> #include <linux/workqueue.h>
>> -#include <linux/i2c/adp8860.h>
>> +#include <linux/platform_data/adp8860.h>
>> #define ADP8860_EXT_FEATURES
>> #define ADP8860_USE_LEDS
>> diff --git a/include/linux/i2c/adp8860.h
>> b/include/linux/platform_data/adp8860.h
>> similarity index 100%
>> rename from include/linux/i2c/adp8860.h
>> rename to include/linux/platform_data/adp8860.h
>>
>
>


--
Greetings,
Michael

--
Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne