From: Jan Kiszka <[email protected]>
So far, "(null)" is reported for the node that is missing clocks.
Signed-off-by: Jan Kiszka <[email protected]>
---
drivers/soc/ti/pruss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
index f22ac1edbdd0..afc8aae68035 100644
--- a/drivers/soc/ti/pruss.c
+++ b/drivers/soc/ti/pruss.c
@@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
clks_np = of_get_child_by_name(cfg_node, "clocks");
if (!clks_np) {
- dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
+ dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
return -ENODEV;
}
--
2.26.2
On 6/21/21 1:08 PM, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> So far, "(null)" is reported for the node that is missing clocks.
>
> Signed-off-by: Jan Kiszka <[email protected]>
Acked-by: Suman Anna <[email protected]>
> ---
> drivers/soc/ti/pruss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
> index f22ac1edbdd0..afc8aae68035 100644
> --- a/drivers/soc/ti/pruss.c
> +++ b/drivers/soc/ti/pruss.c
> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>
> clks_np = of_get_child_by_name(cfg_node, "clocks");
> if (!clks_np) {
> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
> return -ENODEV;
> }
>
>
On 23.06.21 17:51, Suman Anna wrote:
> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <[email protected]>
>>
>> So far, "(null)" is reported for the node that is missing clocks.
>>
>> Signed-off-by: Jan Kiszka <[email protected]>
>
> Acked-by: Suman Anna <[email protected]>
>
>> ---
>> drivers/soc/ti/pruss.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>> index f22ac1edbdd0..afc8aae68035 100644
>> --- a/drivers/soc/ti/pruss.c
>> +++ b/drivers/soc/ti/pruss.c
>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>
>> clks_np = of_get_child_by_name(cfg_node, "clocks");
>> if (!clks_np) {
>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>> return -ENODEV;
>> }
>>
>>
>
This was not merged yet. Is it queued somewhere?
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
On 01.09.21 17:03, Jan Kiszka wrote:
> On 23.06.21 17:51, Suman Anna wrote:
>> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <[email protected]>
>>>
>>> So far, "(null)" is reported for the node that is missing clocks.
>>>
>>> Signed-off-by: Jan Kiszka <[email protected]>
>>
>> Acked-by: Suman Anna <[email protected]>
>>
>>> ---
>>> drivers/soc/ti/pruss.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>>> index f22ac1edbdd0..afc8aae68035 100644
>>> --- a/drivers/soc/ti/pruss.c
>>> +++ b/drivers/soc/ti/pruss.c
>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>>
>>> clks_np = of_get_child_by_name(cfg_node, "clocks");
>>> if (!clks_np) {
>>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>>> return -ENODEV;
>>> }
>>>
>>>
>>
>
> This was not merged yet. Is it queued somewhere?
>
> Jan
>
Second reminder - still not seeing this in upstream.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
+ Nishanth
On 11/20/21 1:53 AM, Jan Kiszka wrote:
> On 01.09.21 17:03, Jan Kiszka wrote:
>> On 23.06.21 17:51, Suman Anna wrote:
>>> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>>>> From: Jan Kiszka <[email protected]>
>>>>
>>>> So far, "(null)" is reported for the node that is missing clocks.
>>>>
>>>> Signed-off-by: Jan Kiszka <[email protected]>
>>>
>>> Acked-by: Suman Anna <[email protected]>
>>>
>>>> ---
>>>> drivers/soc/ti/pruss.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>>>> index f22ac1edbdd0..afc8aae68035 100644
>>>> --- a/drivers/soc/ti/pruss.c
>>>> +++ b/drivers/soc/ti/pruss.c
>>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>>>
>>>> clks_np = of_get_child_by_name(cfg_node, "clocks");
>>>> if (!clks_np) {
>>>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>>>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>>>> return -ENODEV;
>>>> }
>>>>
>>>>
>>>
>>
>> This was not merged yet. Is it queued somewhere?
>>
>> Jan
>>
>
> Second reminder - still not seeing this in upstream.
Nishanth,
Can you pick this up?
regards
Suman
Hi Jan Kiszka,
On Mon, 21 Jun 2021 20:08:28 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> So far, "(null)" is reported for the node that is missing clocks.
>
>
I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!
[1/1] soc: ti: pruss: fix referenced node in error message
commit: 8aa35e0bb5eaa42bac415ad0847985daa7b4890c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D