2020-01-18 10:48:01

by sachin agarwal

Subject: [PATCH 4/4] GPIO: creg-snps: fixed a typo

From: Sachin agarwal <[email protected]>

we had written "valiue" rather than "value".

Signed-off-by: Sachin Agarwal <[email protected]>
---
drivers/gpio/gpio-creg-snps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index ff19a8ad5663..3705cf993c7e 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
return -EINVAL;

- /* Check that on valiue fits it's placeholder */
+ /* Check that on value fits it's placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
return -EINVAL;

- /* Check that off valiue fits it's placeholder */
+ /* Check that off value fits it's placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
return -EINVAL;

--
2.24.1

2020-01-18 17:31:43

by Joe Perches

Subject: Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo

On Sat, 2020-01-18 at 16:15 +0530, sachin agarwal wrote:
> From: Sachin agarwal <[email protected]>
>
> we had written "valiue" rather than "value".
[]
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
[]
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
> if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
> return -EINVAL;
>
> - /* Check that on valiue fits it's placeholder */
> + /* Check that on value fits it's placeholder */

Might as well fix the it's/its usages too.

> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
> return -EINVAL;
>
> - /* Check that off valiue fits it's placeholder */
> + /* Check that off value fits it's placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
> return -EINVAL;
>