2022-06-28 10:44:45

by Andrew Lunn

Subject: Re: [PATCH] drivers/net/usb/r8152: Enable MAC address passthru support

On Tue, Jun 28, 2022 at 09:53:25AM +0800, Franklin Lin wrote:
> From: franklin_lin <[email protected]>
>
> Enable the support for providing a MAC address
> for a dock to use based on the VPD values set in the platform.

Maybe i'm missing it, but i don't see any code which verifies this
r8152 is actually in the dock, and not a USB ethernet dongle plugged
into some port of either the laptop or the dock itself.

Andrew

2022-06-28 11:42:28

by Oliver Neukum

Subject: Re: [PATCH] drivers/net/usb/r8152: Enable MAC address passthru support

On 28.06.22 12:17, Andrew Lunn wrote:
> On Tue, Jun 28, 2022 at 09:53:25AM +0800, Franklin Lin wrote:
>> From: franklin_lin <[email protected]>
>>
>> Enable the support for providing a MAC address
>> for a dock to use based on the VPD values set in the platform.
>
> Maybe i'm missing it, but i don't see any code which verifies this
> r8152 is actually in the dock, and not a USB ethernet dongle plugged
> into some port of either the laptop or the dock itself.

And it will happily assign the same MAC to multiple devices.
I am afraid this patch needs some basic redesign.

Regards
Oliver