2017-11-07 03:54:32

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] selftests: futex: fix compilation error

On 11/05/2017 09:03 PM, Lei Yang wrote:
> I run into below error when building futext
> /bin/sh: -c: line 5: syntax error: unexpected end of file
>
> the closing ";" and "\" are necessary.
> My OS is "Ubuntu 14.04.5 LTS"
>
> Signed-off-by: Lei Yang <[email protected]>
> ---
> tools/testing/selftests/futex/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index f0c0369..943f3a2 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,9 +11,9 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> - if [ -e $$DIR/$(TEST_PROGS) ]; then
> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> - fi
> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> + fi \
> done
>
> override define RUN_TESTS
>

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

thanks,
-- Shuah

From 1583368255140838022@xxx Tue Nov 07 01:20:38 +0000 2017
X-GM-THRID: 1583288022901438905
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-06 23:50:05

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] selftests: futex: fix compilation error

On 11/06/2017 04:45 PM, Shuah Khan wrote:
> On 11/05/2017 09:03 PM, Lei Yang wrote:
>> I run into below error when building futext
>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>
>> the closing ";" and "\" are necessary.
>> My OS is "Ubuntu 14.04.5 LTS"
>>
>> Signed-off-by: Lei Yang <[email protected]>
>> ---
>> tools/testing/selftests/futex/Makefile | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>> index f0c0369..943f3a2 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -11,9 +11,9 @@ all:
>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>> mkdir $$BUILD_TARGET -p; \
>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>> - fi
>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>> + fi \
>> done
>>
>> override define RUN_TESTS
>>
>
> Hmm. I don't see this error on linux_4.14-rc8?
>
> Can you give more details on the gcc version you are using?


I meant gnumake version? I am not seeing the failure with what I am
using

thanks,
-- Shuah


From 1583288022901438905@xxx Mon Nov 06 04:05:22 +0000 2017
X-GM-THRID: 1583288022901438905
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread