2020-10-07 03:50:14

by Pawel Laszczak

Subject: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

Patch removes not used variable 'length' from
cdns3_wa2_descmiss_copy_data function.

Signed-off-by: Pawel Laszczak <[email protected]>
---
drivers/usb/cdns3/gadget.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 6e7b70a2e352..692acf7b9b14 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,

while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
int chunk_end;
- int length;

descmiss_priv_req =
cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
break;

chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
- length = request->actual + descmiss_req->actual;
request->status = descmiss_req->status;
__cdns3_descmiss_copy_data(request, descmiss_req);
list_del_init(&descmiss_priv_req->list);
--
2.17.1

2020-10-07 10:56:38

by Sergei Shtylyov

Subject: Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

Hello!

On 10/7/20 11:15 AM, Roger Quadros wrote:

[...]
>> Patch removes not used variable 'length' from
>> cdns3_wa2_descmiss_copy_data function.
>>
>> Signed-off-by: Pawel Laszczak <[email protected]>
>
> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")

No "commit" is needed here.

> Acked-by: Roger Quadros <[email protected]>
[...]

MBR, Sergei

2020-10-07 15:25:43

by Roger Quadros

Subject: Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

On 07/10/2020 06:39, Pawel Laszczak wrote:
> Patch removes not used variable 'length' from
> cdns3_wa2_descmiss_copy_data function.
>
> Signed-off-by: Pawel Laszczak <[email protected]>

Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")

Acked-by: Roger Quadros <[email protected]>

> ---
> drivers/usb/cdns3/gadget.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 6e7b70a2e352..692acf7b9b14 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>
> while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
> int chunk_end;
> - int length;
>
> descmiss_priv_req =
> cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
> @@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
> break;
>
> chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
> - length = request->actual + descmiss_req->actual;
> request->status = descmiss_req->status;
> __cdns3_descmiss_copy_data(request, descmiss_req);
> list_del_init(&descmiss_priv_req->list);
>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2020-10-08 04:01:18

by Pawel Laszczak

Subject: RE: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

Siergei,

>
>On 10/7/20 11:15 AM, Roger Quadros wrote:
>
>[...]
>>> Patch removes not used variable 'length' from
>>> cdns3_wa2_descmiss_copy_data function.
>>>
>>> Signed-off-by: Pawel Laszczak <[email protected]>
>>
>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>
> No "commit" is needed here.

Can you explain why?

I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
or because it's only warning - not error.

Am I right ?

>
>> Acked-by: Roger Quadros <[email protected]>
>[...]
>

Regards,
Pawel

2020-10-08 07:32:54

by Roger Quadros

Subject: Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

Pawel,

On 08/10/2020 06:57, Pawel Laszczak wrote:
> Siergei,
>
>>
>> On 10/7/20 11:15 AM, Roger Quadros wrote:
>>
>> [...]
>>>> Patch removes not used variable 'length' from
>>>> cdns3_wa2_descmiss_copy_data function.
>>>>
>>>> Signed-off-by: Pawel Laszczak <[email protected]>
>>>
>>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>>
>> No "commit" is needed here.
>
> Can you explain why?
>
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
>
> Am I right ?

Siergei meant that the word "commit" should not be used. So it should be

Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")

cheers,
-roger

>
>>
>>> Acked-by: Roger Quadros <[email protected]>
>> [...]
>>
>
> Regards,
> Pawel
>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2020-10-08 11:28:26

by Sergei Shtylyov

Subject: Re: [PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

Hello!

On 08.10.2020 6:57, Pawel Laszczak wrote:

> Siergei,

Sergei, or, more correctly, Sergey. :-)

>
>>
>> On 10/7/20 11:15 AM, Roger Quadros wrote:
>>
>> [...]
>>>> Patch removes not used variable 'length' from
>>>> cdns3_wa2_descmiss_copy_data function.
>>>>
>>>> Signed-off-by: Pawel Laszczak <[email protected]>
>>>
>>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>>
>> No "commit" is needed here.
>
> Can you explain why?
>
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
>
> Am I right ?

No, it's because the format is:

Fixes: <SHA1> ("<summary>")

no word "commit" is needed. :-)

>>> Acked-by: Roger Quadros <[email protected]>
>> [...]
>
> Regards,
> Pawel

MBR, Sergei