2018-07-09 17:52:28

by Taeung Song

Subject: [PATCH v2] samples/bpf: Fix tc and ip paths in xdp2skb_meta.sh

The below path error can occur:

# ./xdp2skb_meta.sh --dev eth0 --list
./xdp2skb_meta.sh: line 61: /usr/sbin/tc: No such file or directory

So just use command names instead of absolute paths of tc and ip.
In addition, it allow callers to redefine $TC and $IP paths

Fixes: 36e04a2d78d9 ("samples/bpf: xdp2skb_meta shows transferring info from XDP to SKB")
Reviewed-by: Jesper Dangaard Brouer <[email protected]>
Signed-off-by: Taeung Song <[email protected]>
---
samples/bpf/xdp2skb_meta.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/samples/bpf/xdp2skb_meta.sh b/samples/bpf/xdp2skb_meta.sh
index b9c9549c4c27..4bde9d066c46 100755
--- a/samples/bpf/xdp2skb_meta.sh
+++ b/samples/bpf/xdp2skb_meta.sh
@@ -16,8 +16,8 @@
BPF_FILE=xdp2skb_meta_kern.o
DIR=$(dirname $0)

-export TC=/usr/sbin/tc
-export IP=/usr/sbin/ip
+[ -z "$TC" ] && TC=tc
+[ -z "$IP" ] && IP=ip

function usage() {
echo ""
@@ -53,7 +53,7 @@ function _call_cmd() {
local allow_fail="$2"
shift 2
if [[ -n "$VERBOSE" ]]; then
- echo "$(basename $cmd) $@"
+ echo "$cmd $@"
fi
if [[ -n "$DRYRUN" ]]; then
return
--
2.17.1

2018-07-09 19:18:37

by Jesper Dangaard Brouer

Subject: Re: [PATCH v2] samples/bpf: Fix tc and ip paths in xdp2skb_meta.sh

On Tue, 10 Jul 2018 02:51:21 +0900
Taeung Song <[email protected]> wrote:

> The below path error can occur:
>
> # ./xdp2skb_meta.sh --dev eth0 --list
> ./xdp2skb_meta.sh: line 61: /usr/sbin/tc: No such file or directory
>
> So just use command names instead of absolute paths of tc and ip.
> In addition, it allow callers to redefine $TC and $IP paths
>
> Fixes: 36e04a2d78d9 ("samples/bpf: xdp2skb_meta shows transferring info from XDP to SKB")
> Reviewed-by: Jesper Dangaard Brouer <[email protected]>
> Signed-off-by: Taeung Song <[email protected]>

Acked-by: Jesper Dangaard Brouer <[email protected]>

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer

2018-07-10 07:21:35

by Daniel Borkmann

Subject: Re: [PATCH v2] samples/bpf: Fix tc and ip paths in xdp2skb_meta.sh

On 07/09/2018 07:51 PM, Taeung Song wrote:
> The below path error can occur:
>
> # ./xdp2skb_meta.sh --dev eth0 --list
> ./xdp2skb_meta.sh: line 61: /usr/sbin/tc: No such file or directory
>
> So just use command names instead of absolute paths of tc and ip.
> In addition, it allow callers to redefine $TC and $IP paths
>
> Fixes: 36e04a2d78d9 ("samples/bpf: xdp2skb_meta shows transferring info from XDP to SKB")
> Reviewed-by: Jesper Dangaard Brouer <[email protected]>
> Signed-off-by: Taeung Song <[email protected]>

Applied to bpf, thanks Taeung!