2020-11-01 12:25:22

by Marc Zyngier

[permalink] [raw]
Subject: [GIT PULL] irqchip updates for 5.10, take #1

Hi Thomas,

Here's a smallish set of fixes for 5.10. Some fixes after the
IPI-as-IRQ (I expect a couple more next week), two significant bug
fixes for the SiFive PLIC, and a TI update to handle their "unmapped
events". The rest is the usual set of cleanups and tidying up.

Please pull,

M.

The following changes since commit 63ea38a402213d8c9c16e58ee4901ff51bc8fe3c:

Merge branch 'irq/mstar' into irq/irqchip-next (2020-10-10 12:46:54 +0100)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git tags/irqchip-fixes-5.10-1

for you to fetch changes up to d95bdca75b3fb41bf185efe164e05aed820081a5:

irqchip/ti-sci-inta: Add support for unmapped event handling (2020-11-01 12:00:50 +0000)

----------------------------------------------------------------
irqchip fixes for Linux 5.10, take #1

- A couple of fixes after the IPI as IRQ patches (Kconfig, bcm2836)
- Two SiFive PLIC fixes (irq_set_affinity, hierarchy handling)
- "unmapped events" handling for the ti-sci-inta controller
- Tidying up for the irq-mst driver (static functions, Kconfig)
- Small cleanup in the Renesas irqpin driver
- STM32 exti can now handle LP timer events

----------------------------------------------------------------
Fabrice Gasnier (1):
irqchip/stm32-exti: Add all LP timer exti direct events support

Geert Uytterhoeven (2):
irqchip/mst: MST_IRQ should depend on ARCH_MEDIATEK or ARCH_MSTARV7
irqchip/renesas-intc-irqpin: Merge irlm_bit and needs_irlm

Greentime Hu (2):
irqchip/sifive-plic: Fix broken irq_set_affinity() callback
irqchip/sifive-plic: Fix chip_data access within a hierarchy

Marc Zyngier (4):
genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY
irqchip/mst: Make mst_intc_of_init static
irqchip/mips: Drop selection of IRQ_DOMAIN_HIERARCHY
irqchip/bcm2836: Fix missing __init annotation

Peter Ujfalusi (2):
dt-bindings: irqchip: ti, sci-inta: Update for unmapped event handling
irqchip/ti-sci-inta: Add support for unmapped event handling

.../bindings/interrupt-controller/ti,sci-inta.yaml | 10 +++
drivers/irqchip/Kconfig | 3 +-
drivers/irqchip/irq-bcm2836.c | 2 +-
drivers/irqchip/irq-mst-intc.c | 4 +-
drivers/irqchip/irq-renesas-intc-irqpin.c | 8 +--
drivers/irqchip/irq-sifive-plic.c | 10 +--
drivers/irqchip/irq-stm32-exti.c | 4 ++
drivers/irqchip/irq-ti-sci-inta.c | 83 +++++++++++++++++++++-
kernel/irq/Kconfig | 1 +
9 files changed, 107 insertions(+), 18 deletions(-)


2020-11-03 13:43:32

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [GIT PULL] irqchip updates for 5.10, take #1

On Sun, Nov 1, 2020 at 6:22 AM Marc Zyngier <[email protected]> wrote:
>
> Hi Thomas,
>
> Here's a smallish set of fixes for 5.10. Some fixes after the
> IPI-as-IRQ (I expect a couple more next week), two significant bug
> fixes for the SiFive PLIC, and a TI update to handle their "unmapped
> events". The rest is the usual set of cleanups and tidying up.
>
> Please pull,
>
> M.
>
> The following changes since commit 63ea38a402213d8c9c16e58ee4901ff51bc8fe3c:
>
> Merge branch 'irq/mstar' into irq/irqchip-next (2020-10-10 12:46:54 +0100)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git tags/irqchip-fixes-5.10-1
>
> for you to fetch changes up to d95bdca75b3fb41bf185efe164e05aed820081a5:
>
> irqchip/ti-sci-inta: Add support for unmapped event handling (2020-11-01 12:00:50 +0000)
>
> ----------------------------------------------------------------
> irqchip fixes for Linux 5.10, take #1
>
> - A couple of fixes after the IPI as IRQ patches (Kconfig, bcm2836)
> - Two SiFive PLIC fixes (irq_set_affinity, hierarchy handling)
> - "unmapped events" handling for the ti-sci-inta controller
> - Tidying up for the irq-mst driver (static functions, Kconfig)
> - Small cleanup in the Renesas irqpin driver
> - STM32 exti can now handle LP timer events
>
> ----------------------------------------------------------------
> Fabrice Gasnier (1):
> irqchip/stm32-exti: Add all LP timer exti direct events support
>
> Geert Uytterhoeven (2):
> irqchip/mst: MST_IRQ should depend on ARCH_MEDIATEK or ARCH_MSTARV7
> irqchip/renesas-intc-irqpin: Merge irlm_bit and needs_irlm
>
> Greentime Hu (2):
> irqchip/sifive-plic: Fix broken irq_set_affinity() callback
> irqchip/sifive-plic: Fix chip_data access within a hierarchy
>
> Marc Zyngier (4):
> genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY
> irqchip/mst: Make mst_intc_of_init static
> irqchip/mips: Drop selection of IRQ_DOMAIN_HIERARCHY
> irqchip/bcm2836: Fix missing __init annotation
>
> Peter Ujfalusi (2):
> dt-bindings: irqchip: ti, sci-inta: Update for unmapped event handling

This breaks dt_binding_check in linux-next:

Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py",
line 343, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py",
line 111, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 891, in
_ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.parser.ParserError: while parsing a block mapping
in "<unicode string>", line 4, column 1
did not find expected key
in "<unicode string>", line 37, column 2
make[1]: *** [Documentation/devicetree/bindings/Makefile:20:
Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dts]
Error 1
make[1]: *** Deleting file
'Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dts'
./Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml:37:2:
[error] syntax error: expected <block end>, but found '<scalar>'
(syntax)

Looks like it's the block diagram change which needs more indentation.

Rob

2020-11-03 13:54:00

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: [GIT PULL] irqchip updates for 5.10, take #1

Rob,

On 03/11/2020 15.39, Rob Herring wrote:
> On Sun, Nov 1, 2020 at 6:22 AM Marc Zyngier <[email protected]> wrote:
>>
>> Hi Thomas,
>>
>> Here's a smallish set of fixes for 5.10. Some fixes after the
>> IPI-as-IRQ (I expect a couple more next week), two significant bug
>> fixes for the SiFive PLIC, and a TI update to handle their "unmapped
>> events". The rest is the usual set of cleanups and tidying up.
>>
>> Please pull,
>>
>> M.
>>
>> The following changes since commit 63ea38a402213d8c9c16e58ee4901ff51bc8fe3c:
>>
>> Merge branch 'irq/mstar' into irq/irqchip-next (2020-10-10 12:46:54 +0100)
>>
>> are available in the Git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git tags/irqchip-fixes-5.10-1
>>
>> for you to fetch changes up to d95bdca75b3fb41bf185efe164e05aed820081a5:
>>
>> irqchip/ti-sci-inta: Add support for unmapped event handling (2020-11-01 12:00:50 +0000)
>>
>> ----------------------------------------------------------------
>> irqchip fixes for Linux 5.10, take #1
>>
>> - A couple of fixes after the IPI as IRQ patches (Kconfig, bcm2836)
>> - Two SiFive PLIC fixes (irq_set_affinity, hierarchy handling)
>> - "unmapped events" handling for the ti-sci-inta controller
>> - Tidying up for the irq-mst driver (static functions, Kconfig)
>> - Small cleanup in the Renesas irqpin driver
>> - STM32 exti can now handle LP timer events
>>
>> ----------------------------------------------------------------
>> Fabrice Gasnier (1):
>> irqchip/stm32-exti: Add all LP timer exti direct events support
>>
>> Geert Uytterhoeven (2):
>> irqchip/mst: MST_IRQ should depend on ARCH_MEDIATEK or ARCH_MSTARV7
>> irqchip/renesas-intc-irqpin: Merge irlm_bit and needs_irlm
>>
>> Greentime Hu (2):
>> irqchip/sifive-plic: Fix broken irq_set_affinity() callback
>> irqchip/sifive-plic: Fix chip_data access within a hierarchy
>>
>> Marc Zyngier (4):
>> genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY
>> irqchip/mst: Make mst_intc_of_init static
>> irqchip/mips: Drop selection of IRQ_DOMAIN_HIERARCHY
>> irqchip/bcm2836: Fix missing __init annotation
>>
>> Peter Ujfalusi (2):
>> dt-bindings: irqchip: ti, sci-inta: Update for unmapped event handling
>
> This breaks dt_binding_check in linux-next:
>
> Traceback (most recent call last):
> File "/usr/local/bin/dt-extract-example", line 45, in <module>
> binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
> File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py",
> line 343, in load
> return constructor.get_single_data()
> File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py",
> line 111, in get_single_data
> node = self.composer.get_single_node()
> File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
> File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
> File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
> File "_ruamel_yaml.pyx", line 891, in
> _ruamel_yaml.CParser._compose_mapping_node
> File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
> ruamel.yaml.parser.ParserError: while parsing a block mapping
> in "<unicode string>", line 4, column 1
> did not find expected key
> in "<unicode string>", line 37, column 2
> make[1]: *** [Documentation/devicetree/bindings/Makefile:20:
> Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dts]
> Error 1
> make[1]: *** Deleting file
> 'Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dts'
> ./Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml:37:2:
> [error] syntax error: expected <block end>, but found '<scalar>'
> (syntax)
>
> Looks like it's the block diagram change which needs more indentation.

Sorry, I have sent a fix:
https://lore.kernel.org/lkml/[email protected]/

>
> Rob
>

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki