2020-09-22 13:26:25

by Yue Haibing

Subject: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()

There is no caller in tree, so can remove it.

Signed-off-by: YueHaibing <[email protected]>
---
kernel/sched/core.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2d95dc3f4644..1b06b952dbbe 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
return clamp_value / UCLAMP_BUCKET_DELTA;
}

-static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
-{
- return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
-}
-
static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
{
if (clamp_id == UCLAMP_MIN)
--
2.17.1

2020-09-23 10:23:24

by Dietmar Eggemann

Subject: Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()

On 22/09/2020 15:24, YueHaibing wrote:
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> kernel/sched/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
> return clamp_value / UCLAMP_BUCKET_DELTA;
> }
>
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> - return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
> static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
> {
> if (clamp_id == UCLAMP_MIN)
>

LGTM.

It got introduced in commit 60daf9c194106 ("sched/uclamp: Add bucket
local max tracking") but was never used.

Reviewed-by: Dietmar Eggemann <[email protected]>

2020-09-25 14:13:52

by Vincent Guittot

Subject: Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()

On Tue, 22 Sep 2020 at 15:24, YueHaibing <[email protected]> wrote:
>
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Vincent Guittot <[email protected]>

> ---
> kernel/sched/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
> return clamp_value / UCLAMP_BUCKET_DELTA;
> }
>
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> - return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
> static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
> {
> if (clamp_id == UCLAMP_MIN)
> --
> 2.17.1
>

2020-09-29 08:00:54

by tip-bot2 for Alexey Makhalov

Subject: [tip: sched/core] sched: Remove unused inline function uclamp_bucket_base_value()

The following commit has been merged into the sched/core branch of tip:

Commit-ID: 51bd5121c4eb25b911f6bc1ab4de5fe865fe0dcb
Gitweb: https://git.kernel.org/tip/51bd5121c4eb25b911f6bc1ab4de5fe865fe0dcb
Author: YueHaibing <[email protected]>
AuthorDate: Tue, 22 Sep 2020 21:24:10 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Fri, 25 Sep 2020 14:23:25 +02:00

sched: Remove unused inline function uclamp_bucket_base_value()

There is no caller in tree, so can remove it.

Signed-off-by: YueHaibing <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Dietmar Eggemann <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/sched/core.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c36dc1a..dd32d85 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
return clamp_value / UCLAMP_BUCKET_DELTA;
}

-static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
-{
- return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
-}
-
static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
{
if (clamp_id == UCLAMP_MIN)