2023-08-04 08:18:33

by Greg KH

Subject: [PATCH] mm: no need to export mm_kobj

There are no modules using mm_kobj, so do not export it.

Cc: Mike Rapoport <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
mm/mm_init.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index a1963c3322af..1c9d6f428906 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
#endif /* CONFIG_DEBUG_MEMORY_INIT */

struct kobject *mm_kobj;
-EXPORT_SYMBOL_GPL(mm_kobj);

#ifdef CONFIG_SMP
s32 vm_committed_as_batch = 32;
--
2.41.0

2023-08-04 08:46:13

by Mike Rapoport

Subject: Re: [PATCH] mm: no need to export mm_kobj

On Fri, Aug 04, 2023 at 08:43:37AM +0200, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.
>
> Cc: Mike Rapoport <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>

Reviewed-by: Mike Rapoport (IBM) <[email protected]>

> ---
> mm/mm_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
> #endif /* CONFIG_DEBUG_MEMORY_INIT */
>
> struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>
> #ifdef CONFIG_SMP
> s32 vm_committed_as_batch = 32;
> --
> 2.41.0
>

--
Sincerely yours,
Mike.

2023-08-04 09:03:19

by Miaohe Lin

Subject: Re: [PATCH] mm: no need to export mm_kobj

On 2023/8/4 14:43, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.

Yes, there's only in-kernel user left.

Reviewed-by: Miaohe Lin <[email protected]>

Thanks.

>
> Cc: Mike Rapoport <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> mm/mm_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
> #endif /* CONFIG_DEBUG_MEMORY_INIT */
>
> struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>
> #ifdef CONFIG_SMP
> s32 vm_committed_as_batch = 32;
>

2023-08-07 16:19:16

by David Hildenbrand

Subject: Re: [PATCH] mm: no need to export mm_kobj

On 04.08.23 08:43, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.
>
> Cc: Mike Rapoport <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> mm/mm_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
> #endif /* CONFIG_DEBUG_MEMORY_INIT */
>
> struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>
> #ifdef CONFIG_SMP
> s32 vm_committed_as_batch = 32;

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb