2019-03-20 14:19:44

by Yue Haibing

Subject: [PATCH -next] KVM: arm: vgic: Make two functions static

From: YueHaibing <[email protected]>

Fix sparse warnings:

arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1732:5: warning:
symbol 'vgic_its_has_attr_regs' was not declared. Should it be static?
arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1753:5: warning:
symbol 'vgic_its_attr_regs_access' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
virt/kvm/arm/vgic/vgic-its.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
index ab3f477..a97db69 100644
--- a/virt/kvm/arm/vgic/vgic-its.c
+++ b/virt/kvm/arm/vgic/vgic-its.c
@@ -1729,8 +1729,8 @@ static void vgic_its_destroy(struct kvm_device *kvm_dev)
kfree(its);
}

-int vgic_its_has_attr_regs(struct kvm_device *dev,
- struct kvm_device_attr *attr)
+static int vgic_its_has_attr_regs(struct kvm_device *dev,
+ struct kvm_device_attr *attr)
{
const struct vgic_register_region *region;
gpa_t offset = attr->attr;
@@ -1750,9 +1750,9 @@ int vgic_its_has_attr_regs(struct kvm_device *dev,
return 0;
}

-int vgic_its_attr_regs_access(struct kvm_device *dev,
- struct kvm_device_attr *attr,
- u64 *reg, bool is_write)
+static int vgic_its_attr_regs_access(struct kvm_device *dev,
+ struct kvm_device_attr *attr,
+ u64 *reg, bool is_write)
{
const struct vgic_register_region *region;
struct vgic_its *its;
--
2.7.0

2019-03-20 17:37:55

by Marc Zyngier

Subject: Re: [PATCH -next] KVM: arm: vgic: Make two functions static

On Wed, 20 Mar 2019 22:18:13 +0800
Yue Haibing <[email protected]> wrote:

> From: YueHaibing <[email protected]>
>
> Fix sparse warnings:
>
> arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1732:5: warning:
> symbol 'vgic_its_has_attr_regs' was not declared. Should it be static?
> arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1753:5: warning:
> symbol 'vgic_its_attr_regs_access' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Applied with a small tweak to the subject line.

Thanks,

M.
--
Without deviation from the norm, progress is not possible.

2019-03-20 19:09:53

by Mukesh Ojha

Subject: Re: [PATCH -next] KVM: arm: vgic: Make two functions static

On 3/20/2019 7:48 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warnings:
>
> arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1732:5: warning:
> symbol 'vgic_its_has_attr_regs' was not declared. Should it be static?
> arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1753:5: warning:
> symbol 'vgic_its_attr_regs_access' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> virt/kvm/arm/vgic/vgic-its.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
> index ab3f477..a97db69 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -1729,8 +1729,8 @@ static void vgic_its_destroy(struct kvm_device *kvm_dev)
> kfree(its);
> }
>
> -int vgic_its_has_attr_regs(struct kvm_device *dev,
> - struct kvm_device_attr *attr)
> +static int vgic_its_has_attr_regs(struct kvm_device *dev,
> + struct kvm_device_attr *attr)
> {
> const struct vgic_register_region *region;
> gpa_t offset = attr->attr;
> @@ -1750,9 +1750,9 @@ int vgic_its_has_attr_regs(struct kvm_device *dev,
> return 0;
> }
>
> -int vgic_its_attr_regs_access(struct kvm_device *dev,
> - struct kvm_device_attr *attr,
> - u64 *reg, bool is_write)
> +static int vgic_its_attr_regs_access(struct kvm_device *dev,
> + struct kvm_device_attr *attr,
> + u64 *reg, bool is_write)
> {
> const struct vgic_register_region *region;
> struct vgic_its *its;


Acked-by: Mukesh Ojha <[email protected]>

Cheers,
Mukesh