2022-09-02 08:28:32

by CGEL

Subject: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

From: zhang songyi <[email protected]>

Return the enable_link_dp() directly instead of storing it in another
redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: zhang songyi <[email protected]>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index f9b798b7933c..4ab27e231337 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
struct dc_state *state,
struct pipe_ctx *pipe_ctx)
{
- enum dc_status status;
-
- status = enable_link_dp(state, pipe_ctx);
-
- return status;
+ return enable_link_dp(state, pipe_ctx);
}

static enum dc_status enable_link_dp_mst(
--
2.25.1

2022-09-06 17:02:42

by Rodrigo Siqueira Jordao

Subject: Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

On 2022-09-02 03:54, [email protected] wrote:
> From: zhang songyi <[email protected]>
>
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: zhang songyi <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
> struct dc_state *state,
> struct pipe_ctx *pipe_ctx)
> {
> - enum dc_status status;
> -
> - status = enable_link_dp(state, pipe_ctx);
> -
> - return status;
> + return enable_link_dp(state, pipe_ctx);
> }
>
> static enum dc_status enable_link_dp_mst(

LGTM,

Reviewed-by: Rodrigo Siqueira <[email protected]>

and applied to amd-staging-drm-next.

Thanks
Siqueira