2018-05-15 14:45:15

by Paul Menzel

[permalink] [raw]
Subject: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Dear Linux folks,


Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
Sid/unstable.

```
[…]
[ 0.440240] usb: port power management may be unreliable
[ 0.441358] usbcore: registered new interface driver usb-storage
[ 0.441367] usbcore: registered new interface driver usbserial_generic
[ 0.441369] usbserial: USB Serial support registered for generic
[ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2,
got 0x0
[ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
[…]
```

1. Are the ioremap and ucsi_acpi error related or is a separate report
needed?
2. Do you know the reason for the ucsi_acpi error?


Kind regards,

Paul


Attachments:
=?utf-8?Q?20180515=E2=80=93linux=5F4=2E17-rc5=E2=80=93dmesg=2Etxt?= (55.30 kB)
smime.p7s (5.05 kB)
S/MIME Cryptographic Signature
Download all attachments

2018-05-15 16:02:24

by Greg KH

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> Dear Linux folks,
>
>
> Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> Sid/unstable.
>
> ```
> […]
> [ 0.440240] usb: port power management may be unreliable
> [ 0.441358] usbcore: registered new interface driver usb-storage
> [ 0.441367] usbcore: registered new interface driver usbserial_generic
> [ 0.441369] usbserial: USB Serial support registered for generic
> [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> 0x0
> [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> […]
> ```
>
> 1. Are the ioremap and ucsi_acpi error related or is a separate report
> needed?

The ioremap error is what causes ucsi_acpi to fail the probe call (-12
is "out of memory".)

> 2. Do you know the reason for the ucsi_acpi error?

the call to ioremap failed.

Does this device really have a working typec connector? Does normal USB
devices work with it?

thanks,

greg k-h

2018-05-15 16:48:39

by Paul Menzel

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Dear Greg,


As always, thank you for the prompt response.


On 05/15/18 18:00, Greg KH wrote:
> On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:

>> Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
>> Sid/unstable.
>>
>> ```
>> […]
>> [ 0.440240] usb: port power management may be unreliable
>> [ 0.441358] usbcore: registered new interface driver usb-storage
>> [ 0.441367] usbcore: registered new interface driver usbserial_generic
>> [ 0.441369] usbserial: USB Serial support registered for generic
>> [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
>> 0x0
>> [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
>> […]
>> ```
>>
>> 1. Are the ioremap and ucsi_acpi error related or is a separate report
>> needed?
>
> The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> is "out of memory".)
>
>> 2. Do you know the reason for the ucsi_acpi error?
>
> the call to ioremap failed.
>
> Does this device really have a working typec connector?

Just to avoid misunderstandings, no device was connected to the laptop
during my test.

But, from other boots, the Dell docking station TB16 kind of works with
it, so I’d say the USB Type-C connector is working.

> Does normal USB devices work with it?

Sorry for being ignorant, but could you please tell me what normal USB
devices are?


Kind regards,

Paul


Attachments:
smime.p7s (5.05 kB)
S/MIME Cryptographic Signature

2018-05-16 08:03:50

by Greg KH

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
> Dear Greg,
>
>
> As always, thank you for the prompt response.
>
>
> On 05/15/18 18:00, Greg KH wrote:
> > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
>
> > > Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> > > Sid/unstable.
> > >
> > > ```
> > > […]
> > > [ 0.440240] usb: port power management may be unreliable
> > > [ 0.441358] usbcore: registered new interface driver usb-storage
> > > [ 0.441367] usbcore: registered new interface driver usbserial_generic
> > > [ 0.441369] usbserial: USB Serial support registered for generic
> > > [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> > > 0x0
> > > [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> > > […]
> > > ```
> > >
> > > 1. Are the ioremap and ucsi_acpi error related or is a separate report
> > > needed?
> >
> > The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> > is "out of memory".)
> >
> > > 2. Do you know the reason for the ucsi_acpi error?
> >
> > the call to ioremap failed.
> >
> > Does this device really have a working typec connector?
>
> Just to avoid misunderstandings, no device was connected to the laptop
> during my test.
>
> But, from other boots, the Dell docking station TB16 kind of works with it,
> so I’d say the USB Type-C connector is working.

Ok, good, this might just be the acpi tables not set up properly for
this type of connection. Odd that the tables show it should work,
Heikki should know more about this.

> > Does normal USB devices work with it?
>
> Sorry for being ignorant, but could you please tell me what normal USB
> devices are?

If you plug a USB typeC device into this port, does it work? A docking
station is a little bit "different" in that it usually uses the PCIe
connection, not the USB connectors. Or at least that's how my Dell
docking station works last time I tried it[1]

thanks,

greg k-h

[1] When the power supply for the docking station is bigger than the
laptop's power supply, you begin to wonder what is in that thing and
stop using it after a while...

2018-05-16 12:00:19

by Heikki Krogerus

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Hi,

On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
> On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
> > Dear Greg,
> >
> >
> > As always, thank you for the prompt response.
> >
> >
> > On 05/15/18 18:00, Greg KH wrote:
> > > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> >
> > > > Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> > > > Sid/unstable.
> > > >
> > > > ```
> > > > [???]
> > > > [ 0.440240] usb: port power management may be unreliable
> > > > [ 0.441358] usbcore: registered new interface driver usb-storage
> > > > [ 0.441367] usbcore: registered new interface driver usbserial_generic
> > > > [ 0.441369] usbserial: USB Serial support registered for generic
> > > > [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> > > > 0x0
> > > > [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> > > > [???]
> > > > ```
> > > >
> > > > 1. Are the ioremap and ucsi_acpi error related or is a separate report
> > > > needed?
> > >
> > > The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> > > is "out of memory".)
> > >
> > > > 2. Do you know the reason for the ucsi_acpi error?
> > >
> > > the call to ioremap failed.
> > >
> > > Does this device really have a working typec connector?
> >
> > Just to avoid misunderstandings, no device was connected to the laptop
> > during my test.
> >
> > But, from other boots, the Dell docking station TB16 kind of works with it,
> > so I???d say the USB Type-C connector is working.
>
> Ok, good, this might just be the acpi tables not set up properly for
> this type of connection. Odd that the tables show it should work,
> Heikki should know more about this.

The firmware probable has not implemented UCSI on this board. I think
Dell always supplies the ACPI device node for UCSI in their acpi
tables. The _STA method in that device node is then used to inform the
OS if the interface exists or not. The return value for _STA comes
probable from BIOS, so this is most likely a BIOS problem.

Please note that UCSI will only supply status information to the
operating system, so the USB Type-C ports will function normally even
without it. The ports are handled in firmware on these platforms.

Paul, do you have the latest BIOS?


> > > Does normal USB devices work with it?
> >
> > Sorry for being ignorant, but could you please tell me what normal USB
> > devices are?
>
> If you plug a USB typeC device into this port, does it work? A docking
> station is a little bit "different" in that it usually uses the PCIe
> connection, not the USB connectors. Or at least that's how my Dell
> docking station works last time I tried it[1]
>
> thanks,
>
> greg k-h
>
> [1] When the power supply for the docking station is bigger than the
> laptop's power supply, you begin to wonder what is in that thing and
> stop using it after a while...

Br,

--
heikki

2018-05-16 12:37:05

by Paul Menzel

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Dear Heikki,


On 05/16/18 13:58, Heikki Krogerus wrote:

> On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
>> On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:

>>> On 05/15/18 18:00, Greg KH wrote:
>>>> On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
>>>
>>>>> Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
>>>>> Sid/unstable.
>>>>>
>>>>> ```
>>>>> [???]
>>>>> [ 0.440240] usb: port power management may be unreliable
>>>>> [ 0.441358] usbcore: registered new interface driver usb-storage
>>>>> [ 0.441367] usbcore: registered new interface driver usbserial_generic
>>>>> [ 0.441369] usbserial: USB Serial support registered for generic
>>>>> [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
>>>>> 0x0
>>>>> [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
>>>>> [???]
>>>>> ```
>>>>>
>>>>> 1. Are the ioremap and ucsi_acpi error related or is a separate report
>>>>> needed?
>>>>
>>>> The ioremap error is what causes ucsi_acpi to fail the probe call (-12
>>>> is "out of memory".)
>>>>
>>>>> 2. Do you know the reason for the ucsi_acpi error?
>>>>
>>>> the call to ioremap failed.
>>>>
>>>> Does this device really have a working typec connector?
>>>
>>> Just to avoid misunderstandings, no device was connected to the laptop
>>> during my test.
>>>
>>> But, from other boots, the Dell docking station TB16 kind of works with it,
>>> so I???d say the USB Type-C connector is working.
>>
>> Ok, good, this might just be the acpi tables not set up properly for
>> this type of connection. Odd that the tables show it should work,
>> Heikki should know more about this.
>
> The firmware probable has not implemented UCSI on this board. I think
> Dell always supplies the ACPI device node for UCSI in their acpi
> tables. The _STA method in that device node is then used to inform the
> OS if the interface exists or not. The return value for _STA comes
> probable from BIOS, so this is most likely a BIOS problem.
>
> Please note that UCSI will only supply status information to the
> operating system, so the USB Type-C ports will function normally even
> without it. The ports are handled in firmware on these platforms.
>
> Paul, do you have the latest BIOS?

I had the latest firmware

> DMI: Dell Inc. XPS 13 9370/0F6P3V, BIOS 1.2.1 02/21/2018

until today, when 1.3.2 with the changes below was released [1].

Mario, it’d be great, if the Dell firmware team could start testing with
Linux releases too to find such issues. Mario, could you please also
check internally if the Dell firmware team is aware of the issues and
can incorporate a fix. (I really wish the firmware would be free
software, so that these issues could be fixed ourselves.)

> Fixes & Enhancements
> Fixes:
> - Battery can't charge over 55%
> - Incorrect Ctrl+Alt+Del log on message with HID Event filter driver
> - Platform can't boot to the PXE boot environment in Legacy mode via DA300
> - Correct the flash utility string typo
> - PCIE Card error shows in Support Assist Tool
> - Fail 'PCR1 changed' msg prompt in CMD during running TPM PCR cycles in OS
> - The PCI-to-PCI Bridge will lost while connecting to Dell Thunderbolt Dock TB18
> - Adjust fan speed
> - Skips keys when typing fast
>
> Enhancements:
> - None

It’ll take me up to some days to get my hands on the device again. But
the update should be easy enough thanks to Dell supporting fwupd with
UEFI Capsule and uploading their updates to the Linux Vendor Firmware
Service [2].


Kind regards,

Paul


[1]
http://www.dell.com/support/home/us/en/04/drivers/driversdetails?driverId=VF23P
[2] https://fwupd.org/


Attachments:
smime.p7s (5.05 kB)
S/MIME Cryptographic Signature

2018-05-16 15:05:05

by Mario Limonciello

[permalink] [raw]
Subject: RE: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370



> -----Original Message-----
> From: Paul Menzel [mailto:[email protected]]
> Sent: Wednesday, May 16, 2018 7:36 AM
> To: Heikki Krogerus
> Cc: Greg KH; [email protected]; [email protected]; Limonciello,
> Mario
> Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13
> 9370
>
> Dear Heikki,
>
>
> On 05/16/18 13:58, Heikki Krogerus wrote:
>
> > On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
> >> On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
>
> >>> On 05/15/18 18:00, Greg KH wrote:
> >>>> On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> >>>
> >>>>> Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> >>>>> Sid/unstable.
> >>>>>
> >>>>> ```
> >>>>> [???]
> >>>>> [ 0.440240] usb: port power management may be unreliable
> >>>>> [ 0.441358] usbcore: registered new interface driver usb-storage
> >>>>> [ 0.441367] usbcore: registered new interface driver usbserial_generic
> >>>>> [ 0.441369] usbserial: USB Serial support registered for generic
> >>>>> [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> >>>>> 0x0
> >>>>> [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> >>>>> [???]
> >>>>> ```
> >>>>>
> >>>>> 1. Are the ioremap and ucsi_acpi error related or is a separate report
> >>>>> needed?
> >>>>
> >>>> The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> >>>> is "out of memory".)
> >>>>
> >>>>> 2. Do you know the reason for the ucsi_acpi error?
> >>>>
> >>>> the call to ioremap failed.
> >>>>
> >>>> Does this device really have a working typec connector?
> >>>
> >>> Just to avoid misunderstandings, no device was connected to the laptop
> >>> during my test.
> >>>
> >>> But, from other boots, the Dell docking station TB16 kind of works with it,
> >>> so I???d say the USB Type-C connector is working.
> >>
> >> Ok, good, this might just be the acpi tables not set up properly for
> >> this type of connection. Odd that the tables show it should work,
> >> Heikki should know more about this.
> >
> > The firmware probable has not implemented UCSI on this board. I think
> > Dell always supplies the ACPI device node for UCSI in their acpi
> > tables. The _STA method in that device node is then used to inform the
> > OS if the interface exists or not. The return value for _STA comes
> > probable from BIOS, so this is most likely a BIOS problem.
> >
> > Please note that UCSI will only supply status information to the
> > operating system, so the USB Type-C ports will function normally even
> > without it. The ports are handled in firmware on these platforms.
> >
> > Paul, do you have the latest BIOS?
>
> I had the latest firmware
>
> > DMI: Dell Inc. XPS 13 9370/0F6P3V, BIOS 1.2.1 02/21/2018
>
> until today, when 1.3.2 with the changes below was released [1].
>
> Mario, it’d be great, if the Dell firmware team could start testing with
> Linux releases too to find such issues.

Paul,

The team that sustains platforms does perform Linux testing, but it's not
centered around latest upstream kernel and it's also functionally based (not
reviewing dmesg for new kernel errors) so there are changes in
expectations (viewed as regressions) as you find from time to time.

> Mario, could you please also
> check internally if the Dell firmware team is aware of the issues and
> can incorporate a fix.

Sure I'll inquire internally.

> > Fixes & Enhancements
> > Fixes:
> > - Battery can't charge over 55%
> > - Incorrect Ctrl+Alt+Del log on message with HID Event filter driver
> > - Platform can't boot to the PXE boot environment in Legacy mode via DA300
> > - Correct the flash utility string typo
> > - PCIE Card error shows in Support Assist Tool
> > - Fail 'PCR1 changed' msg prompt in CMD during running TPM PCR cycles in OS
> > - The PCI-to-PCI Bridge will lost while connecting to Dell Thunderbolt Dock TB18
> > - Adjust fan speed
> > - Skips keys when typing fast
> >
> > Enhancements:
> > - None
>
> It’ll take me up to some days to get my hands on the device again. But
> the update should be easy enough thanks to Dell supporting fwupd with
> UEFI Capsule and uploading their updates to the Linux Vendor Firmware
> Service [2].
>
>
> Kind regards,
>
> Paul
>
>
> [1]
> http://www.dell.com/support/home/us/en/04/drivers/driversdetails?driverId=VF23P
> [2] https://fwupd.org/

2018-05-16 16:14:20

by Mario Limonciello

[permalink] [raw]
Subject: RE: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370



> -----Original Message-----
> From: Heikki Krogerus [mailto:[email protected]]
> Sent: Wednesday, May 16, 2018 6:58 AM
> To: Greg KH; Paul Menzel
> Cc: [email protected]; [email protected]; Limonciello, Mario
> Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13
> 9370
>
> Hi,
>
> On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
> > On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
> > > Dear Greg,
> > >
> > >
> > > As always, thank you for the prompt response.
> > >
> > >
> > > On 05/15/18 18:00, Greg KH wrote:
> > > > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> > >
> > > > > Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> > > > > Sid/unstable.
> > > > >
> > > > > ```
> > > > > [???]
> > > > > [ 0.440240] usb: port power management may be unreliable
> > > > > [ 0.441358] usbcore: registered new interface driver usb-storage
> > > > > [ 0.441367] usbcore: registered new interface driver usbserial_generic
> > > > > [ 0.441369] usbserial: USB Serial support registered for generic
> > > > > [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> > > > > 0x0
> > > > > [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> > > > > [???]
> > > > > ```
> > > > >
> > > > > 1. Are the ioremap and ucsi_acpi error related or is a separate report
> > > > > needed?
> > > >
> > > > The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> > > > is "out of memory".)
> > > >
> > > > > 2. Do you know the reason for the ucsi_acpi error?
> > > >
> > > > the call to ioremap failed.
> > > >
> > > > Does this device really have a working typec connector?
> > >
> > > Just to avoid misunderstandings, no device was connected to the laptop
> > > during my test.
> > >
> > > But, from other boots, the Dell docking station TB16 kind of works with it,
> > > so I???d say the USB Type-C connector is working.
> >
> > Ok, good, this might just be the acpi tables not set up properly for
> > this type of connection. Odd that the tables show it should work,
> > Heikki should know more about this.
>
> The firmware probable has not implemented UCSI on this board. I think
> Dell always supplies the ACPI device node for UCSI in their acpi
> tables. The _STA method in that device node is then used to inform the
> OS if the interface exists or not. The return value for _STA comes
> probable from BIOS, so this is most likely a BIOS problem.

Heikki,

I confirmed with internal team that UCSI is implemented on XPS 9370
and was confirmed to be working properly with Windows 10 RS2+.

The reason that _STA is responding on this device node now but wasn't
previously is it wasn't exposed in Linux until 4.16 when the Win 10 RS2
OSI string started to respond.

Intel should internally have some XPS 9370 you can remotely access if
you would like to poke around ACPI tables some.

>
> Please note that UCSI will only supply status information to the
> operating system, so the USB Type-C ports will function normally even
> without it. The ports are handled in firmware on these platforms.
>
> Paul, do you have the latest BIOS?
>
>
> > > > Does normal USB devices work with it?
> > >
> > > Sorry for being ignorant, but could you please tell me what normal USB
> > > devices are?
> >
> > If you plug a USB typeC device into this port, does it work? A docking
> > station is a little bit "different" in that it usually uses the PCIe
> > connection, not the USB connectors. Or at least that's how my Dell
> > docking station works last time I tried it[1]

I think the best description here is "Non-Thunderbolt" USB type C device.
Some examples:
There are Dell docking stations with Thunderbolt (TB16) or without (WD15).

You can also pick up little dongles for ethernet or combo dongles for
ethernet/VGA/HDMI/etc.

Anything non-Thunderbolt would satisfy what Greg was looking for.

> >
> > thanks,
> >
> > greg k-h
> >
> > [1] When the power supply for the docking station is bigger than the
> > laptop's power supply, you begin to wonder what is in that thing and
> > stop using it after a while...

Mostly to satisfy letting the docking station work with beefier machines and
still deliver power up to what USB PD will negotiate.
I think they can actually run with smaller power supplies but you will need
something "a little" bigger than regular system power supply to power the
dock and system both.


2018-05-16 16:40:54

by Greg KH

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

On Wed, May 16, 2018 at 04:13:31PM +0000, [email protected] wrote:
> > > [1] When the power supply for the docking station is bigger than the
> > > laptop's power supply, you begin to wonder what is in that thing and
> > > stop using it after a while...
>
> Mostly to satisfy letting the docking station work with beefier machines and
> still deliver power up to what USB PD will negotiate.
> I think they can actually run with smaller power supplies but you will need
> something "a little" bigger than regular system power supply to power the
> dock and system both.

Given the date of my docking station (2+ years old), I would be _amazed_
if it could do USB PD. But I should go try it, my existing Dell laptop
doesn't support that, but I have an Acer here, along with some
chromebooks that do.

I guess I need to go get the latest Dell laptop, "just to test" with :)

thanks,

greg k-h

2018-05-17 09:01:33

by Heikki Krogerus

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Hi,

On Wed, May 16, 2018 at 04:13:31PM +0000, [email protected] wrote:
>
>
> > -----Original Message-----
> > From: Heikki Krogerus [mailto:[email protected]]
> > Sent: Wednesday, May 16, 2018 6:58 AM
> > To: Greg KH; Paul Menzel
> > Cc: [email protected]; [email protected]; Limonciello, Mario
> > Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13
> > 9370
> >
> > Hi,
> >
> > On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
> > > On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
> > > > Dear Greg,
> > > >
> > > >
> > > > As always, thank you for the prompt response.
> > > >
> > > >
> > > > On 05/15/18 18:00, Greg KH wrote:
> > > > > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> > > >
> > > > > > Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> > > > > > Sid/unstable.
> > > > > >
> > > > > > ```
> > > > > > [???]
> > > > > > [ 0.440240] usb: port power management may be unreliable
> > > > > > [ 0.441358] usbcore: registered new interface driver usb-storage
> > > > > > [ 0.441367] usbcore: registered new interface driver usbserial_generic
> > > > > > [ 0.441369] usbserial: USB Serial support registered for generic
> > > > > > [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> > > > > > 0x0
> > > > > > [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> > > > > > [???]
> > > > > > ```
> > > > > >
> > > > > > 1. Are the ioremap and ucsi_acpi error related or is a separate report
> > > > > > needed?
> > > > >
> > > > > The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> > > > > is "out of memory".)
> > > > >
> > > > > > 2. Do you know the reason for the ucsi_acpi error?
> > > > >
> > > > > the call to ioremap failed.
> > > > >
> > > > > Does this device really have a working typec connector?
> > > >
> > > > Just to avoid misunderstandings, no device was connected to the laptop
> > > > during my test.
> > > >
> > > > But, from other boots, the Dell docking station TB16 kind of works with it,
> > > > so I???d say the USB Type-C connector is working.
> > >
> > > Ok, good, this might just be the acpi tables not set up properly for
> > > this type of connection. Odd that the tables show it should work,
> > > Heikki should know more about this.
> >
> > The firmware probable has not implemented UCSI on this board. I think
> > Dell always supplies the ACPI device node for UCSI in their acpi
> > tables. The _STA method in that device node is then used to inform the
> > OS if the interface exists or not. The return value for _STA comes
> > probable from BIOS, so this is most likely a BIOS problem.
>
> Heikki,
>
> I confirmed with internal team that UCSI is implemented on XPS 9370
> and was confirmed to be working properly with Windows 10 RS2+.

Just to double check: "UCSI was confirmed working properly", so not
"the Type-C ports were confirmed working properly"?

> The reason that _STA is responding on this device node now but wasn't
> previously is it wasn't exposed in Linux until 4.16 when the Win 10 RS2
> OSI string started to respond.

OK.

> Intel should internally have some XPS 9370 you can remotely access if
> you would like to poke around ACPI tables some.

I will try get access to XPS 9370, but with the acpi tables, if
somebody could just send me acpidump, that would be enough:

% acpidump -o xps9370_acpi.dump

> > Please note that UCSI will only supply status information to the
> > operating system, so the USB Type-C ports will function normally even
> > without it. The ports are handled in firmware on these platforms.
> >
> > Paul, do you have the latest BIOS?
> >
> >
> > > > > Does normal USB devices work with it?
> > > >
> > > > Sorry for being ignorant, but could you please tell me what normal USB
> > > > devices are?
> > >
> > > If you plug a USB typeC device into this port, does it work? A docking
> > > station is a little bit "different" in that it usually uses the PCIe
> > > connection, not the USB connectors. Or at least that's how my Dell
> > > docking station works last time I tried it[1]
>
> I think the best description here is "Non-Thunderbolt" USB type C device.
> Some examples:
> There are Dell docking stations with Thunderbolt (TB16) or without (WD15).
>
> You can also pick up little dongles for ethernet or combo dongles for
> ethernet/VGA/HDMI/etc.
>
> Anything non-Thunderbolt would satisfy what Greg was looking for.

Anything non-Thunderbolt and non-display.

With the display adapters you would be in DisplayPort alternate mode,
and you would again not be testing a normal USB device.

It never hurts to check that, but I think it's safe to assume that the
ports are functioning normally if the Thunderbolt dock was working.
Unless I'm mistaken, even the xHCI USB host controller behind the
USB Type-C (thunderbolt) ports is actually part of the thunderbolt
controller.


Br,

--
heikki

2018-05-17 13:03:24

by Mario Limonciello

[permalink] [raw]
Subject: RE: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

> -----Original Message-----
> From: Heikki Krogerus [mailto:[email protected]]
> Sent: Thursday, May 17, 2018 4:00 AM
> To: Limonciello, Mario
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13
> 9370
>
> Hi,
>
> On Wed, May 16, 2018 at 04:13:31PM +0000, [email protected] wrote:
> >
> >
> > > -----Original Message-----
> > > From: Heikki Krogerus [mailto:[email protected]]
> > > Sent: Wednesday, May 16, 2018 6:58 AM
> > > To: Greg KH; Paul Menzel
> > > Cc: [email protected]; [email protected]; Limonciello, Mario
> > > Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13
> > > 9370
> > >
> > > Hi,
> > >
> > > On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
> > > > On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
> > > > > Dear Greg,
> > > > >
> > > > >
> > > > > As always, thank you for the prompt response.
> > > > >
> > > > >
> > > > > On 05/15/18 18:00, Greg KH wrote:
> > > > > > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> > > > >
> > > > > > > Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> > > > > > > Sid/unstable.
> > > > > > >
> > > > > > > ```
> > > > > > > [???]
> > > > > > > [ 0.440240] usb: port power management may be unreliable
> > > > > > > [ 0.441358] usbcore: registered new interface driver usb-storage
> > > > > > > [ 0.441367] usbcore: registered new interface driver usbserial_generic
> > > > > > > [ 0.441369] usbserial: USB Serial support registered for generic
> > > > > > > [ 0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2,
> got
> > > > > > > 0x0
> > > > > > > [ 0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> > > > > > > [???]
> > > > > > > ```
> > > > > > >
> > > > > > > 1. Are the ioremap and ucsi_acpi error related or is a separate report
> > > > > > > needed?
> > > > > >
> > > > > > The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> > > > > > is "out of memory".)
> > > > > >
> > > > > > > 2. Do you know the reason for the ucsi_acpi error?
> > > > > >
> > > > > > the call to ioremap failed.
> > > > > >
> > > > > > Does this device really have a working typec connector?
> > > > >
> > > > > Just to avoid misunderstandings, no device was connected to the laptop
> > > > > during my test.
> > > > >
> > > > > But, from other boots, the Dell docking station TB16 kind of works with it,
> > > > > so I???d say the USB Type-C connector is working.
> > > >
> > > > Ok, good, this might just be the acpi tables not set up properly for
> > > > this type of connection. Odd that the tables show it should work,
> > > > Heikki should know more about this.
> > >
> > > The firmware probable has not implemented UCSI on this board. I think
> > > Dell always supplies the ACPI device node for UCSI in their acpi
> > > tables. The _STA method in that device node is then used to inform the
> > > OS if the interface exists or not. The return value for _STA comes
> > > probable from BIOS, so this is most likely a BIOS problem.
> >
> > Heikki,
> >
> > I confirmed with internal team that UCSI is implemented on XPS 9370
> > and was confirmed to be working properly with Windows 10 RS2+.
>
> Just to double check: "UCSI was confirmed working properly", so not
> "the Type-C ports were confirmed working properly"?

UCSI was confirmed working properly. FWIW it's a certification requirement
in Windows.

>
> > The reason that _STA is responding on this device node now but wasn't
> > previously is it wasn't exposed in Linux until 4.16 when the Win 10 RS2
> > OSI string started to respond.
>
> OK.
>
> > Intel should internally have some XPS 9370 you can remotely access if
> > you would like to poke around ACPI tables some.
>
> I will try get access to XPS 9370, but with the acpi tables, if
> somebody could just send me acpidump, that would be enough:
>
> % acpidump -o xps9370_acpi.dump
>
> > > Please note that UCSI will only supply status information to the
> > > operating system, so the USB Type-C ports will function normally even
> > > without it. The ports are handled in firmware on these platforms.
> > >
> > > Paul, do you have the latest BIOS?
> > >
> > >
> > > > > > Does normal USB devices work with it?
> > > > >
> > > > > Sorry for being ignorant, but could you please tell me what normal USB
> > > > > devices are?
> > > >
> > > > If you plug a USB typeC device into this port, does it work? A docking
> > > > station is a little bit "different" in that it usually uses the PCIe
> > > > connection, not the USB connectors. Or at least that's how my Dell
> > > > docking station works last time I tried it[1]
> >
> > I think the best description here is "Non-Thunderbolt" USB type C device.
> > Some examples:
> > There are Dell docking stations with Thunderbolt (TB16) or without (WD15).
> >
> > You can also pick up little dongles for ethernet or combo dongles for
> > ethernet/VGA/HDMI/etc.
> >
> > Anything non-Thunderbolt would satisfy what Greg was looking for.
>
> Anything non-Thunderbolt and non-display.
>
> With the display adapters you would be in DisplayPort alternate mode,
> and you would again not be testing a normal USB device.
>
> It never hurts to check that, but I think it's safe to assume that the
> ports are functioning normally if the Thunderbolt dock was working.
> Unless I'm mistaken, even the xHCI USB host controller behind the
> USB Type-C (thunderbolt) ports is actually part of the thunderbolt
> controller.

In this laptop yes that's true, but isn't a general statement. It's possible
to have USB split mode (ie XHCI comes from PCH).


2018-05-17 13:59:09

by Heikki Krogerus

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Hi Mario,

On Thu, May 17, 2018 at 01:01:20PM +0000, [email protected] wrote:
> > > Heikki,
> > >
> > > I confirmed with internal team that UCSI is implemented on XPS 9370
> > > and was confirmed to be working properly with Windows 10 RS2+.
> >
> > Just to double check: "UCSI was confirmed working properly", so not
> > "the Type-C ports were confirmed working properly"?
>
> UCSI was confirmed working properly. FWIW it's a certification requirement
> in Windows.

OK, thank you for confirming that.

> > > The reason that _STA is responding on this device node now but wasn't
> > > previously is it wasn't exposed in Linux until 4.16 when the Win 10 RS2
> > > OSI string started to respond.
> >
> > OK.
> >
> > > Intel should internally have some XPS 9370 you can remotely access if
> > > you would like to poke around ACPI tables some.
> >
> > I will try get access to XPS 9370, but with the acpi tables, if
> > somebody could just send me acpidump, that would be enough:
> >
> > % acpidump -o xps9370_acpi.dump

I now have the XPS 9370 ACPI tables.


Br,

--
heikki

2018-06-04 09:25:02

by Kacper Pluta

[permalink] [raw]
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

Hey guys!

Just to let you know that I have the same problem on Dell Inspiron 13
7370. Yesterday, I made a test on 4.17RC7 together with the newest BIOS
1.8.0 (released the 1st June 2018) and the problem is still there.

dmesg | grep "error" gives

[    5.888091] ioremap error for 0x9f935000-0x9f936000, requested 0x2,
got 0x0
[    5.888158] ucsi_acpi: probe of USBC000:00 failed with error -12


Do not hesitate if you need more information.


Have a nice day,
Kacper