2022-01-11 00:24:21

by Prabhakar Mahadev Lad

[permalink] [raw]

Subject: [PATCH v2 11/13] media: s5p-g2d: Use platform_get_irq() to get the interrupt

---

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <[email protected]>
---
v1->v2
* No change.
---
drivers/media/platform/s5p-g2d/g2d.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c
index fa0bb31bd2b9..dd8864779a7c 100644
--- a/drivers/media/platform/s5p-g2d/g2d.c
+++ b/drivers/media/platform/s5p-g2d/g2d.c
@@ -623,7 +623,6 @@ static int g2d_probe(struct platform_device *pdev)
{
struct g2d_dev *dev;
struct video_device *vfd;
- struct resource *res;
const struct of_device_id *of_id;
int ret = 0;

@@ -664,14 +663,11 @@ static int g2d_probe(struct platform_device *pdev)
goto put_clk_gate;
}

- res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (!res) {
- dev_err(&pdev->dev, "failed to find IRQ\n");
- ret = -ENXIO;
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
goto unprep_clk_gate;
- }

- dev->irq = res->start;
+ dev->irq = ret;

ret = devm_request_irq(&pdev->dev, dev->irq, g2d_isr,
0, pdev->name, dev);
--
2.17.1

2022-01-11 14:49:42

by Łukasz Stelmach

[permalink] [raw]

Subject: Re: [PATCH v2 11/13] media: s5p-g2d: Use platform_get_irq() to get the interrupt

---

It was <2022-01-11 wto 00:23>, when Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> v1->v2
> * No change.
> ---
> drivers/media/platform/s5p-g2d/g2d.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>

Acked-by: Łukasz Stelmach <[email protected]>

> diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c
> index fa0bb31bd2b9..dd8864779a7c 100644
> --- a/drivers/media/platform/s5p-g2d/g2d.c
> +++ b/drivers/media/platform/s5p-g2d/g2d.c
> @@ -623,7 +623,6 @@ static int g2d_probe(struct platform_device *pdev)
> {
> struct g2d_dev *dev;
> struct video_device *vfd;
> - struct resource *res;
> const struct of_device_id *of_id;
> int ret = 0;
>
> @@ -664,14 +663,11 @@ static int g2d_probe(struct platform_device *pdev)
> goto put_clk_gate;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "failed to find IRQ\n");
> - ret = -ENXIO;
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> goto unprep_clk_gate;
> - }
>
> - dev->irq = res->start;
> + dev->irq = ret;
>
> ret = devm_request_irq(&pdev->dev, dev->irq, g2d_isr,
> 0, pdev->name, dev);

--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

---

Attachments:

signature.asc (487.00 B)