2024-01-17 15:58:11

by Jan Kundrát

Subject: [PATCH] perf build: don't hardcode pkg-config path

On Buildroot and when building for Arm using the Bootlin toolchain, the
actual `pkg-config` is named just `pkg-config`, not
`arm-linux-pkg-config`. This patch allows the external build system
(such as Buildroot) to pass a working path.

This is already done correctly in tools/build/feature/Makefile and
tools/thermal/tmon/Makefile and also fixed in other places many years
ago (9961aa665b70e47d6c80141c4a2482266010f246), but for some reason it
was never fixed in this file.

Signed-off-by: Jan Kundrát <[email protected]>
To: [email protected]
Cc: Yann E. MORIN <[email protected]>
Cc: [email protected]
---
tools/perf/Makefile.perf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 86569f230e60..b69ab2ae77c6 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -188,7 +188,7 @@ HOSTLD ?= ld
HOSTAR ?= ar
CLANG ?= clang

-PKG_CONFIG = $(CROSS_COMPILE)pkg-config
+PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config

RM = rm -f
LN = ln -f
--
2.43.0

2024-01-19 05:16:53

by Namhyung Kim

Subject: Re: [PATCH] perf build: don't hardcode pkg-config path

Hello,

On Wed, Jan 17, 2024 at 7:58 AM Jan Kundrát <[email protected]> wrote:
>
> On Buildroot and when building for Arm using the Bootlin toolchain, the
> actual `pkg-config` is named just `pkg-config`, not
> `arm-linux-pkg-config`. This patch allows the external build system
> (such as Buildroot) to pass a working path.
>
> This is already done correctly in tools/build/feature/Makefile and
> tools/thermal/tmon/Makefile and also fixed in other places many years
> ago (9961aa665b70e47d6c80141c4a2482266010f246), but for some reason it
> was never fixed in this file.
>
> Signed-off-by: Jan Kundrát <[email protected]>
> To: [email protected]
> Cc: Yann E. MORIN <[email protected]>
> Cc: [email protected]

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/perf/Makefile.perf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 86569f230e60..b69ab2ae77c6 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -188,7 +188,7 @@ HOSTLD ?= ld
> HOSTAR ?= ar
> CLANG ?= clang
>
> -PKG_CONFIG = $(CROSS_COMPILE)pkg-config
> +PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
>
> RM = rm -f
> LN = ln -f
> --
> 2.43.0
>
>
>