2022-01-16 06:47:27

by Alfasys

[permalink] [raw]
Subject: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices using command line options

Add an option to bind the uio_dmem_genirq driver to a given device
using command line options.
Make uio_dmem_genirq match uio_pdrv_genirq functionality added in
commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices

using command line option")

CC: Greg Kroah-Hartman <[email protected]>
CC: Damian Hobson-Garcia <[email protected]>
Signed-off-by: Alfred Patriksson <[email protected]>

---

git diff c9e6606c7fe92 #(tag: v5.16-rc8)
diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index 6b5cfa5b0673..7f6c9b594dd4 100644
--- a/drivers/uio/uio_dmem_genirq.c
+++ b/drivers/uio/uio_dmem_genirq.c
@@ -317,10 +317,13 @@ static const struct dev_pm_ops uio_dmem_genirq_dev_pm_ops = {
};


#ifdef CONFIG_OF
-static const struct of_device_id uio_of_genirq_match[] = {
- { /* empty for now */ },
+static struct of_device_id uio_of_genirq_match[] = {
+ { /* This is filled with module_parm */ },
+ { /* Sentinel */ },
};
MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
+module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
#endif

Attachments:
signature.asc (258.00 B)
OpenPGP digital signature

2022-01-19 19:51:08

by Damian Hobson-Garcia

[permalink] [raw]
Subject: Re: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices using command line options

On 2022/01/16 1:42, Alfasys wrote:
> Add an option to bind the uio_dmem_genirq driver to a given device
> using command line options.
> Make uio_dmem_genirq match uio_pdrv_genirq functionality added in
> commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices
>
> using command line option")

A bit of a weird extra line break here, but other than that, looks ok I
think.

Acked-by: Damian Hobson-Garcia <[email protected]>

2022-01-26 22:26:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices using command line options

On Sat, Jan 15, 2022 at 04:42:02PM +0000, Alfasys wrote:
> Add an option to bind the uio_dmem_genirq driver to a given device
> using command line options.
> Make uio_dmem_genirq match uio_pdrv_genirq functionality added in
> commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices
>
> using command line option")
>
> CC: Greg Kroah-Hartman <[email protected]>
> CC: Damian Hobson-Garcia <[email protected]>
> Signed-off-by: Alfred Patriksson <[email protected]>
>
> ---
>
> git diff c9e6606c7fe92 #(tag: v5.16-rc8)
> diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> index 6b5cfa5b0673..7f6c9b594dd4 100644
> --- a/drivers/uio/uio_dmem_genirq.c
> +++ b/drivers/uio/uio_dmem_genirq.c
> @@ -317,10 +317,13 @@ static const struct dev_pm_ops uio_dmem_genirq_dev_pm_ops = {
> };
>
>
> #ifdef CONFIG_OF
> -static const struct of_device_id uio_of_genirq_match[] = {
> - { /* empty for now */ },
> +static struct of_device_id uio_of_genirq_match[] = {
> + { /* This is filled with module_parm */ },
> + { /* Sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
> +module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");

I do not want to add new module parameters, this is not the 1990's
anymore.

thanks,

greg k-h