2021-03-05 09:21:37

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
net/rxrpc/af_rxrpc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
index 41671af6b33f..2b5f89713e36 100644
--- a/net/rxrpc/af_rxrpc.c
+++ b/net/rxrpc/af_rxrpc.c
@@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
switch (rx->sk.sk_state) {
case RXRPC_UNBOUND:
rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
+ break;
case RXRPC_CLIENT_UNBOUND:
case RXRPC_CLIENT_BOUND:
break;
--
2.27.0


2021-04-20 20:12:21

by Gustavo A. R. Silva

[permalink] [raw]
Subject: Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:19, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> net/rxrpc/af_rxrpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
> index 41671af6b33f..2b5f89713e36 100644
> --- a/net/rxrpc/af_rxrpc.c
> +++ b/net/rxrpc/af_rxrpc.c
> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
> switch (rx->sk.sk_state) {
> case RXRPC_UNBOUND:
> rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
> + break;
> case RXRPC_CLIENT_UNBOUND:
> case RXRPC_CLIENT_BOUND:
> break;
>

2021-04-22 01:30:06

by Jeffrey E Altman

[permalink] [raw]
Subject: Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

On 3/5/2021 4:19 AM, Gustavo A. R. Silva ([email protected]) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

This change looks good to me. Although I would also be happy with a
fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <[email protected]>

Attachments:
jaltman.vcf (283.00 B)
 OpenPGP_signature (855.00 B)
OpenPGP digital signature Download all attachments

2021-06-04 22:35:59

by Gustavo A. R. Silva

[permalink] [raw]
Subject: Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:09, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 03:19, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>> ---
>> net/rxrpc/af_rxrpc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
>> index 41671af6b33f..2b5f89713e36 100644
>> --- a/net/rxrpc/af_rxrpc.c
>> +++ b/net/rxrpc/af_rxrpc.c
>> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
>> switch (rx->sk.sk_state) {
>> case RXRPC_UNBOUND:
>> rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
>> + break;
>> case RXRPC_CLIENT_UNBOUND:
>> case RXRPC_CLIENT_BOUND:
>> break;
>>