2022-05-09 05:51:04

by Lizhe

Subject: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline

At the end of get_last_crashkernel(), the judgement of ck_cmdline is
obviously unnecessary and causes redundance, let's clean it up.

Signed-off-by: lizhe <[email protected]>
Acked-by: Baoquan He <[email protected]>
Acked-by: Philipp Rudo <[email protected]>
---
kernel/crash_core.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 256cf6db573c..c232f01a2c54 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
p = strstr(p+1, name);
}

- if (!ck_cmdline)
- return NULL;
-
return ck_cmdline;
}

--
2.25.1

2022-05-09 09:49:08

by Kari Argillander

Subject: Re: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline

On 6.5.2022 7.32, lizhe wrote:
> At the end of get_last_crashkernel(), the judgement of ck_cmdline is
> obviously unnecessary and causes redundance, let's clean it up.
>
> Signed-off-by: lizhe <[email protected]>

Signed off by should be real name. Greg ask this already, but you did
not ever answer [1].

[1]: https://lore.kernel.org/lkml/[email protected]/

> Acked-by: Baoquan He <[email protected]>
> Acked-by: Philipp Rudo <[email protected]>
> ---
> kernel/crash_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 256cf6db573c..c232f01a2c54 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> p = strstr(p+1, name);
> }
>
> - if (!ck_cmdline)
> - return NULL;
> -
> return ck_cmdline;
> }
>