2023-03-10 22:31:11

by Krzysztof Kozlowski

Subject: [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table

The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant here).

drivers/usb/typec/hd3ss3220.c:284:34: error: ‘dev_ids’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/typec/hd3ss3220.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index 746ef3a75b76..8bbeb9b1e439 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -290,7 +290,7 @@ MODULE_DEVICE_TABLE(of, dev_ids);
static struct i2c_driver hd3ss3220_driver = {
.driver = {
.name = "hd3ss3220",
- .of_match_table = of_match_ptr(dev_ids),
+ .of_match_table = dev_ids,
},
.probe_new = hd3ss3220_probe,
.remove = hd3ss3220_remove,
--
2.34.1

2023-03-10 22:31:14

by Krzysztof Kozlowski

Subject: [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused

The driver can be compile tested with !CONFIG_OF making certain data
unused:

drivers/usb/typec/tcpm/fusb302.c:1816:34: error: ‘fusb302_dt_match’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/typec/tcpm/fusb302.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index 1ffce00d94b4..592b0aec782f 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1813,7 +1813,7 @@ static int fusb302_pm_resume(struct device *dev)
return 0;
}

-static const struct of_device_id fusb302_dt_match[] = {
+static const struct of_device_id fusb302_dt_match[] __maybe_unused = {
{.compatible = "fcs,fusb302"},
{},
};
--
2.34.1

2023-03-10 23:22:53

by Guenter Roeck

Subject: Re: [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused

On 3/10/23 14:29, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/usb/typec/tcpm/fusb302.c:1816:34: error: ‘fusb302_dt_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 1ffce00d94b4..592b0aec782f 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1813,7 +1813,7 @@ static int fusb302_pm_resume(struct device *dev)
> return 0;
> }
>
> -static const struct of_device_id fusb302_dt_match[] = {
> +static const struct of_device_id fusb302_dt_match[] __maybe_unused = {
> {.compatible = "fcs,fusb302"},
> {},
> };

2023-03-10 23:23:26

by Guenter Roeck

Subject: Re: [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table

On 3/10/23 14:29, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).
>
> drivers/usb/typec/hd3ss3220.c:284:34: error: ‘dev_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/usb/typec/hd3ss3220.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 746ef3a75b76..8bbeb9b1e439 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -290,7 +290,7 @@ MODULE_DEVICE_TABLE(of, dev_ids);
> static struct i2c_driver hd3ss3220_driver = {
> .driver = {
> .name = "hd3ss3220",
> - .of_match_table = of_match_ptr(dev_ids),
> + .of_match_table = dev_ids,
> },
> .probe_new = hd3ss3220_probe,
> .remove = hd3ss3220_remove,

2023-03-13 09:19:36

by Heikki Krogerus

Subject: Re: [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table

On Fri, Mar 10, 2023 at 11:29:36PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).
>
> drivers/usb/typec/hd3ss3220.c:284:34: error: ‘dev_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/hd3ss3220.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 746ef3a75b76..8bbeb9b1e439 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -290,7 +290,7 @@ MODULE_DEVICE_TABLE(of, dev_ids);
> static struct i2c_driver hd3ss3220_driver = {
> .driver = {
> .name = "hd3ss3220",
> - .of_match_table = of_match_ptr(dev_ids),
> + .of_match_table = dev_ids,
> },
> .probe_new = hd3ss3220_probe,
> .remove = hd3ss3220_remove,
> --
> 2.34.1

--
heikki

2023-03-13 09:20:34

by Heikki Krogerus

Subject: Re: [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused

On Fri, Mar 10, 2023 at 11:29:37PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/usb/typec/tcpm/fusb302.c:1816:34: error: ‘fusb302_dt_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Should this be marked as a fix?

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 1ffce00d94b4..592b0aec782f 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1813,7 +1813,7 @@ static int fusb302_pm_resume(struct device *dev)
> return 0;
> }
>
> -static const struct of_device_id fusb302_dt_match[] = {
> +static const struct of_device_id fusb302_dt_match[] __maybe_unused = {
> {.compatible = "fcs,fusb302"},
> {},
> };
> --
> 2.34.1

--
heikki

2023-03-13 09:21:50

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused

On 13/03/2023 10:20, Heikki Krogerus wrote:
> On Fri, Mar 10, 2023 at 11:29:37PM +0100, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>> drivers/usb/typec/tcpm/fusb302.c:1816:34: error: ‘fusb302_dt_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Should this be marked as a fix?
>

It's a fix for compile test with W=1, so not a real issue.

Best regards,
Krzysztof