The StarFive VisionFive V1 SBC [1] is similar with the already supported
BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
In addition to documenting the necessary compatibles, this patch series
moves most of the content from jh7100-beaglev-starlight.dts to a new file
jh7100-common.dtsi, to be shared between the two boards.
No other changes are required in order to successfully boot the board.
[1] https://github.com/starfive-tech/VisionFive
Cristian Ciocaltea (3):
dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
riscv: dts: starfive: Add common DT for JH7100 based boards
riscv: dts: starfive: Add StarFive VisionFive V1 device tree
.../devicetree/bindings/riscv/starfive.yaml | 3 +
arch/riscv/boot/dts/starfive/Makefile | 2 +-
.../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------
.../boot/dts/starfive/jh7100-common.dtsi | 161 ++++++++++++++++++
.../jh7100-starfive-visionfive-v1.dts | 20 +++
5 files changed, 186 insertions(+), 153 deletions(-)
create mode 100644 arch/riscv/boot/dts/starfive/jh7100-common.dtsi
create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
--
2.37.2
Document the compatibles for StarFive VisionFive V1 SBC [1].
The board is based on the StarFive JH7100 SoC.
[1] https://github.com/starfive-tech/VisionFive
Signed-off-by: Cristian Ciocaltea <[email protected]>
---
Documentation/devicetree/bindings/riscv/starfive.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
index 5b36243fd674..9c948b379c8f 100644
--- a/Documentation/devicetree/bindings/riscv/starfive.yaml
+++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
@@ -21,6 +21,9 @@ properties:
- items:
- const: beagle,beaglev-starlight-jh7100-r0
- const: starfive,jh7100
+ - items:
+ - const: starfive,visionfive-v1
+ - const: starfive,jh7100
additionalProperties: true
--
2.37.2
Add initial device tree for the StarFive VisionFive V1 SBC [1], which
is similar with the already supported BeagleV Starlight Beta board,
both being based on the StarFive JH7100 SoC.
[1] https://github.com/starfive-tech/VisionFive
Signed-off-by: Cristian Ciocaltea <[email protected]>
---
arch/riscv/boot/dts/starfive/Makefile | 2 +-
.../jh7100-starfive-visionfive-v1.dts | 20 +++++++++++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile
index 0ea1bc15ab30..039c143cba33 100644
--- a/arch/riscv/boot/dts/starfive/Makefile
+++ b/arch/riscv/boot/dts/starfive/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb
+dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb jh7100-starfive-visionfive-v1.dtb
diff --git a/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts b/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
new file mode 100644
index 000000000000..e82af72f1aaf
--- /dev/null
+++ b/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: GPL-2.0 OR MIT
+/*
+ * Copyright (C) 2021 StarFive Technology Co., Ltd.
+ * Copyright (C) 2021 Emil Renner Berthing <[email protected]>
+ */
+
+/dts-v1/;
+#include "jh7100-common.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+ model = "StarFive VisionFive V1";
+ compatible = "starfive,visionfive-v1", "starfive,jh7100";
+
+ gpio-restart {
+ compatible = "gpio-restart";
+ gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;
+ priority = <224>;
+ };
+};
--
2.37.2
Hey Cristian,
On 01/09/2022 23:42, Cristian Ciocaltea wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Document the compatibles for StarFive VisionFive V1 SBC [1].
> The board is based on the StarFive JH7100 SoC.
>
> [1] https://github.com/starfive-tech/VisionFive
>
> Signed-off-by: Cristian Ciocaltea <[email protected]>
> ---
> Documentation/devicetree/bindings/riscv/starfive.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> index 5b36243fd674..9c948b379c8f 100644
> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> @@ -21,6 +21,9 @@ properties:
> - items:
> - const: beagle,beaglev-starlight-jh7100-r0
Can you use an enum here please?
> - const: starfive,jh7100
> + - items:
> + - const: starfive,visionfive-v1
> + - const: starfive,jh7100
>
> additionalProperties: true
>
> --
> 2.37.2
>
>
> _______________________________________________
> linux-riscv mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-riscv
On 01/09/2022 23:42, Cristian Ciocaltea wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The StarFive VisionFive V1 SBC [1] is similar with the already supported
> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>
> In addition to documenting the necessary compatibles, this patch series
> moves most of the content from jh7100-beaglev-starlight.dts to a new file
> jh7100-common.dtsi, to be shared between the two boards.
>
> No other changes are required in order to successfully boot the board.
Gave it a go this morning, dts stuff itself looks good to me. No new
warnings, although that's to be expected, & boots fine.
I know that most jn7100 stuff is not really wanted upstream, but I'd
say that the minimal vision5 dts is an exception to that, so with the
one comment on patch 1 resolved:
Reviewed-by: Conor Dooley <[email protected]>
Thanks,
Conor.
>
> [1] https://github.com/starfive-tech/VisionFive
>
> Cristian Ciocaltea (3):
> dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
> riscv: dts: starfive: Add common DT for JH7100 based boards
> riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>
> .../devicetree/bindings/riscv/starfive.yaml | 3 +
> arch/riscv/boot/dts/starfive/Makefile | 2 +-
> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------
> .../boot/dts/starfive/jh7100-common.dtsi | 161 ++++++++++++++++++
> .../jh7100-starfive-visionfive-v1.dts | 20 +++
> 5 files changed, 186 insertions(+), 153 deletions(-)
> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>
> --
> 2.37.2
>
>
> _______________________________________________
> linux-riscv mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-riscv
On 9/2/22 09:27, [email protected] wrote:
> On 01/09/2022 23:42, Cristian Ciocaltea wrote:
>> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> The StarFive VisionFive V1 SBC [1] is similar with the already supported
>> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>>
>> In addition to documenting the necessary compatibles, this patch series
>> moves most of the content from jh7100-beaglev-starlight.dts to a new file
>> jh7100-common.dtsi, to be shared between the two boards.
>>
>> No other changes are required in order to successfully boot the board.
>
> Gave it a go this morning, dts stuff itself looks good to me. No new
> warnings, although that's to be expected, & boots fine.
>
> I know that most jn7100 stuff is not really wanted upstream, but I'd
> say that the minimal vision5 dts is an exception to that, so with the
> one comment on patch 1 resolved:
>
> Reviewed-by: Conor Dooley <[email protected]>
Thanks for the quick review, I have submitted v2:
https://lore.kernel.org/all/[email protected]/
Regards,
Cristian
> Thanks,
> Conor.
>
>>
>> [1] https://github.com/starfive-tech/VisionFive
>>
>> Cristian Ciocaltea (3):
>> dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>> riscv: dts: starfive: Add common DT for JH7100 based boards
>> riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>>
>> .../devicetree/bindings/riscv/starfive.yaml | 3 +
>> arch/riscv/boot/dts/starfive/Makefile | 2 +-
>> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------
>> .../boot/dts/starfive/jh7100-common.dtsi | 161 ++++++++++++++++++
>> .../jh7100-starfive-visionfive-v1.dts | 20 +++
>> 5 files changed, 186 insertions(+), 153 deletions(-)
>> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-common.dtsi
>> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>>
>> --
>> 2.37.2
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> [email protected]
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>