2022-07-20 19:44:46

by Xin Gao

Subject: [PATCH] dma-mapping:do not initialise statics to 0.

do not initialise statics to 0.

Signed-off-by: Xin Gao <[email protected]>
---
arch/parisc/kernel/pci-dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index 160996f2198e..ba87f791323b 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -36,8 +36,8 @@
#include <asm/tlbflush.h> /* for purge_tlb_*() macros */

static struct proc_dir_entry * proc_gsc_root __read_mostly = NULL;
-static unsigned long pcxl_used_bytes __read_mostly = 0;
-static unsigned long pcxl_used_pages __read_mostly = 0;
+static unsigned long pcxl_used_bytes __read_mostly;
+static unsigned long pcxl_used_pages __read_mostly;

extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area */
static DEFINE_SPINLOCK(pcxl_res_lock);
--
2.30.2

2022-07-21 08:24:11

by Helge Deller

Subject: Re: [PATCH] dma-mapping:do not initialise statics to 0.

On 7/20/22 21:39, Xin Gao wrote:
> do not initialise statics to 0.
>
> Signed-off-by: Xin Gao <[email protected]>
> ---
> arch/parisc/kernel/pci-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index 160996f2198e..ba87f791323b 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -36,8 +36,8 @@
> #include <asm/tlbflush.h> /* for purge_tlb_*() macros */
>
> static struct proc_dir_entry * proc_gsc_root __read_mostly = NULL;

While at it, you could remove the "= NULL" as well.

Helge

> -static unsigned long pcxl_used_bytes __read_mostly = 0;
> -static unsigned long pcxl_used_pages __read_mostly = 0;
> +static unsigned long pcxl_used_bytes __read_mostly;
> +static unsigned long pcxl_used_pages __read_mostly;
>
> extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area */
> static DEFINE_SPINLOCK(pcxl_res_lock);