2017-06-29 09:31:27

by Arvind Yadav

Subject: [PATCH] staging: ccree: constify dev_pm_ops structures.

dev_pm_ops are not supposed to change at runtime. All functions
working with dev_pm_ops provided by <linux/device.h> work with const
dev_pm_ops. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
3800 488 0 4288 10c0 drivers/staging/ccree/ssi_driver.o

File size After adding 'const':
text data bss dec hex filename
4010 288 0 4298 10ca drivers/staging/ccree/ssi_driver.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/ccree/ssi_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c
index bc19adc..27e8f63 100644
--- a/drivers/staging/ccree/ssi_driver.c
+++ b/drivers/staging/ccree/ssi_driver.c
@@ -516,7 +516,7 @@ static int cc7x_remove(struct platform_device *plat_dev)
return 0;
}
#if defined (CONFIG_PM_RUNTIME) || defined (CONFIG_PM_SLEEP)
-static struct dev_pm_ops arm_cc7x_driver_pm = {
+static const struct dev_pm_ops arm_cc7x_driver_pm = {
SET_RUNTIME_PM_OPS(ssi_power_mgr_runtime_suspend, ssi_power_mgr_runtime_resume, NULL)
};
#endif
--
1.9.1

2017-06-29 14:17:54

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: ccree: constify dev_pm_ops structures.

On Thu, Jun 29, 2017 at 03:00:28PM +0530, Arvind Yadav wrote:
> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 3800 488 0 4288 10c0 drivers/staging/ccree/ssi_driver.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 4010 288 0 4298 10ca drivers/staging/ccree/ssi_driver.o
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/staging/ccree/ssi_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

No longer applies to my staging-testing branch at all due to other
changes happening there. Please rebase and resend.

thanks,

greg k-h