2019-04-01 06:22:49

by Anson Huang

Subject: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/irqchip/irq-imx-irqsteer.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 88df3d00..290531e 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct irqsteer_data *data;
- struct resource *res;
u32 irqs_num;
int i, ret;

@@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
if (!data)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- data->regs = devm_ioremap_resource(&pdev->dev, res);
+ data->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(data->regs)) {
dev_err(&pdev->dev, "failed to initialize reg\n");
return PTR_ERR(data->regs);
--
2.7.4

2019-04-01 07:48:29

by Mukesh Ojha

Subject: Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

On 4/1/2019 11:51 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh
> ---
> drivers/irqchip/irq-imx-irqsteer.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
> index 88df3d00..290531e 100644
> --- a/drivers/irqchip/irq-imx-irqsteer.c
> +++ b/drivers/irqchip/irq-imx-irqsteer.c
> @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct irqsteer_data *data;
> - struct resource *res;
> u32 irqs_num;
> int i, ret;
>
> @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
> if (!data)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - data->regs = devm_ioremap_resource(&pdev->dev, res);
> + data->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(data->regs)) {
> dev_err(&pdev->dev, "failed to initialize reg\n");
> return PTR_ERR(data->regs);

2019-04-28 06:30:01

by Anson Huang

Subject: RE: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

Ping...

> -----Original Message-----
> From: Mukesh Ojha [mailto:[email protected]]
> Sent: Monday, April 1, 2019 3:47 PM
> To: Anson Huang <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: Re: [PATCH] irqchip/imx-irqsteer: use
> devm_platform_ioremap_resource() to simplify code
>
>
> On 4/1/2019 11:51 AM, Anson Huang wrote:
> > Use the new helper devm_platform_ioremap_resource() which wraps the
> > platform_get_resource() and devm_ioremap_resource() together, to
> > simplify the code.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> Reviewed-by: Mukesh Ojha <[email protected]>
>
> Cheers,
> -Mukesh
> > ---
> > drivers/irqchip/irq-imx-irqsteer.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-imx-irqsteer.c
> > b/drivers/irqchip/irq-imx-irqsteer.c
> > index 88df3d00..290531e 100644
> > --- a/drivers/irqchip/irq-imx-irqsteer.c
> > +++ b/drivers/irqchip/irq-imx-irqsteer.c
> > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct
> platform_device *pdev)
> > {
> > struct device_node *np = pdev->dev.of_node;
> > struct irqsteer_data *data;
> > - struct resource *res;
> > u32 irqs_num;
> > int i, ret;
> >
> > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct
> platform_device *pdev)
> > if (!data)
> > return -ENOMEM;
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - data->regs = devm_ioremap_resource(&pdev->dev, res);
> > + data->regs = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(data->regs)) {
> > dev_err(&pdev->dev, "failed to initialize reg\n");
> > return PTR_ERR(data->regs);

2019-04-28 09:36:50

by Marc Zyngier

Subject: Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

On Sun, 28 Apr 2019 07:28:20 +0100,
Anson Huang <[email protected]> wrote:
>
> Ping...

I'm still building the 5.2 branch, no need to panic just yet.

Thanks,

M.

>
> > -----Original Message-----
> > From: Mukesh Ojha [mailto:[email protected]]
> > Sent: Monday, April 1, 2019 3:47 PM
> > To: Anson Huang <[email protected]>; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]
> > Cc: dl-linux-imx <[email protected]>
> > Subject: Re: [PATCH] irqchip/imx-irqsteer: use
> > devm_platform_ioremap_resource() to simplify code
> >
> >
> > On 4/1/2019 11:51 AM, Anson Huang wrote:
> > > Use the new helper devm_platform_ioremap_resource() which wraps the
> > > platform_get_resource() and devm_ioremap_resource() together, to
> > > simplify the code.
> > >
> > > Signed-off-by: Anson Huang <[email protected]>
> > Reviewed-by: Mukesh Ojha <[email protected]>
> >
> > Cheers,
> > -Mukesh
> > > ---
> > > drivers/irqchip/irq-imx-irqsteer.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c
> > > b/drivers/irqchip/irq-imx-irqsteer.c
> > > index 88df3d00..290531e 100644
> > > --- a/drivers/irqchip/irq-imx-irqsteer.c
> > > +++ b/drivers/irqchip/irq-imx-irqsteer.c
> > > @@ -144,7 +144,6 @@ static int imx_irqsteer_probe(struct
> > platform_device *pdev)
> > > {
> > > struct device_node *np = pdev->dev.of_node;
> > > struct irqsteer_data *data;
> > > - struct resource *res;
> > > u32 irqs_num;
> > > int i, ret;
> > >
> > > @@ -152,8 +151,7 @@ static int imx_irqsteer_probe(struct
> > platform_device *pdev)
> > > if (!data)
> > > return -ENOMEM;
> > >
> > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > - data->regs = devm_ioremap_resource(&pdev->dev, res);
> > > + data->regs = devm_platform_ioremap_resource(pdev, 0);
> > > if (IS_ERR(data->regs)) {
> > > dev_err(&pdev->dev, "failed to initialize reg\n");
> > > return PTR_ERR(data->regs);

--
Jazz is not dead, it just smell funny.