2018-01-17 11:23:19

by Wei Yongjun

Subject: [PATCH -next] memory: ti-emif-sram: remove redundant dev_err call in ti_emif_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/memory/ti-emif-pm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c
index 4ea1514..48cec4f 100644
--- a/drivers/memory/ti-emif-pm.c
+++ b/drivers/memory/ti-emif-pm.c
@@ -271,7 +271,6 @@ static int ti_emif_probe(struct platform_device *pdev)
emif_data->pm_data.ti_emif_base_addr_virt = devm_ioremap_resource(dev,
res);
if (IS_ERR(emif_data->pm_data.ti_emif_base_addr_virt)) {
- dev_err(dev, "could not ioremap emif mem\n");
ret = PTR_ERR(emif_data->pm_data.ti_emif_base_addr_virt);
return ret;
}

2018-01-17 18:05:36

by Santosh Shilimkar

Subject: Re: [PATCH -next] memory: ti-emif-sram: remove redundant dev_err call in ti_emif_probe()

On 1/17/2018 3:29 AM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
Looks fine. Will pick it up for next merge window.

Regards,
Santosh