2024-05-22 04:43:54

by Sergio Paracuellos

[permalink] [raw]
Subject: [PATCH] dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph

MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
Ports. Add PCIe host topology ascii graph to the binding for completeness.

Suggested-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Sergio Paracuellos <[email protected]>
---
.../bindings/pci/mediatek,mt7621-pcie.yaml | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
index 6fba42156db6..c41608863d6c 100644
--- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
@@ -13,6 +13,35 @@ description: |+
MediaTek MT7621 PCIe subsys supports a single Root Complex (RC)
with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link

+ MT7621 PCIe HOST Topology
+
+ .-------.
+ | |
+ | CPU |
+ | |
+ '-------'
+ |
+ |
+ |
+ v
+ .------------------.
+ .-----------| HOST/PCI Bridge |------------.
+ | '------------------' | Type1
+ BUS0 | | | Access
+ v v v On Bus0
+ .-------------. .-------------. .-------------.
+ | VIRTUAL P2P | | VIRTUAL P2P | | VIRTUAL P2P |
+ | BUS0 | | BUS0 | | BUS0 |
+ | DEV0 | | DEV1 | | DEV2 |
+ '-------------' '-------------' '-------------'
+ Type0 | Type0 | Type0 |
+ Access BUS1 | Access BUS2| Access BUS3|
+ On Bus1 v On Bus2 v On Bus3 v
+ .----------. .----------. .----------.
+ | Device 0 | | Device 0 | | Device 0 |
+ | Func 0 | | Func 0 | | Func 0 |
+ '----------' '----------' '----------'
+
allOf:
- $ref: /schemas/pci/pci-host-bridge.yaml#

--
2.25.1



2024-05-22 06:48:25

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph

On 22/05/2024 06:43, Sergio Paracuellos wrote:
> MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
> Ports. Add PCIe host topology ascii graph to the binding for completeness.
>
> Suggested-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
> .../bindings/pci/mediatek,mt7621-pcie.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


Subject: Re: [PATCH] dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph

Il 22/05/24 06:43, Sergio Paracuellos ha scritto:
> MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
> Ports. Add PCIe host topology ascii graph to the binding for completeness.
>
> Suggested-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>

Lovely.

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

> ---
> .../bindings/pci/mediatek,mt7621-pcie.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> index 6fba42156db6..c41608863d6c 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> @@ -13,6 +13,35 @@ description: |+
> MediaTek MT7621 PCIe subsys supports a single Root Complex (RC)
> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
>
> + MT7621 PCIe HOST Topology
> +
> + .-------.
> + | |
> + | CPU |
> + | |
> + '-------'
> + |
> + |
> + |
> + v
> + .------------------.
> + .-----------| HOST/PCI Bridge |------------.
> + | '------------------' | Type1
> + BUS0 | | | Access
> + v v v On Bus0
> + .-------------. .-------------. .-------------.
> + | VIRTUAL P2P | | VIRTUAL P2P | | VIRTUAL P2P |
> + | BUS0 | | BUS0 | | BUS0 |
> + | DEV0 | | DEV1 | | DEV2 |
> + '-------------' '-------------' '-------------'
> + Type0 | Type0 | Type0 |
> + Access BUS1 | Access BUS2| Access BUS3|
> + On Bus1 v On Bus2 v On Bus3 v
> + .----------. .----------. .----------.
> + | Device 0 | | Device 0 | | Device 0 |
> + | Func 0 | | Func 0 | | Func 0 |
> + '----------' '----------' '----------'
> +
> allOf:
> - $ref: /schemas/pci/pci-host-bridge.yaml#
>