2023-07-20 16:36:12

by Frank Ramsay

Subject: [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets.

MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8 sockets or fewer.
On a system with more than 8 sockets intel-speed-select silently ignores everything
beyond the 8th socket, rendering the tool useless for those systems.

Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets.

Signed-off-by: Frank Ramsay <[email protected]>
---
tools/power/x86/intel-speed-select/isst.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/intel-speed-select/isst.h b/tools/power/x86/intel-speed-select/isst.h
index 54fc21575d56..8def22dec4a2 100644
--- a/tools/power/x86/intel-speed-select/isst.h
+++ b/tools/power/x86/intel-speed-select/isst.h
@@ -79,7 +79,7 @@

#define DISP_FREQ_MULTIPLIER 100

-#define MAX_PACKAGE_COUNT 8
+#define MAX_PACKAGE_COUNT 32
#define MAX_DIE_PER_PACKAGE 2
#define MAX_PUNIT_PER_DIE 8

--
2.39.1

2023-07-20 16:56:42

by srinivas pandruvada

Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets.

On Thu, 2023-07-20 at 11:08 -0500, Frank Ramsay wrote:
> MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8
> sockets or fewer.
> On a system with more than 8 sockets intel-speed-select silently
> ignores everything
> beyond the 8th socket, rendering the tool useless for those systems.
>
> Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets.
>
Thanks for the patch. I will queue this for the next release.

-Srinivas

> Signed-off-by: Frank Ramsay <[email protected]>
> ---
>  tools/power/x86/intel-speed-select/isst.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst.h
> b/tools/power/x86/intel-speed-select/isst.h
> index 54fc21575d56..8def22dec4a2 100644
> --- a/tools/power/x86/intel-speed-select/isst.h
> +++ b/tools/power/x86/intel-speed-select/isst.h
> @@ -79,7 +79,7 @@
>  
>  #define DISP_FREQ_MULTIPLIER 100
>  
> -#define MAX_PACKAGE_COUNT      8
> +#define MAX_PACKAGE_COUNT      32
>  #define MAX_DIE_PER_PACKAGE    2
>  #define MAX_PUNIT_PER_DIE      8
>