Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2
Compact smartphones.
Signed-off-by: Konrad Dybcio <[email protected]>
---
Changes since v1:
- remove device-specific compatibles in favour of panel-common
height/width-mm properties
- fix indentation in the example
.../display/panel/sony,td4353-jdi.yaml | 82 +++++++++++++++++++
1 file changed, 82 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml b/Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml
new file mode 100644
index 000000000000..7915c993e83e
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/sony,td4353-jdi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony TD4353 JDI 5 / 5.7" 2160x1080 MIPI-DSI Panel
+
+maintainers:
+ - Konrad Dybcio <[email protected]>
+
+description: |
+ The Sony TD4353 JDI is a 5 (XZ2c) / 5.7 (XZ2) inch 2160x1080
+ MIPI-DSI panel, used in Xperia XZ2 and XZ2 Compact smartphones.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: sony,td4353-jdi-tama
+
+ reg: true
+
+ backlight: true
+
+ vddio-supply:
+ description: VDDIO 1.8V supply
+
+ vsp-supply:
+ description: Positive 5.5V supply
+
+ vsn-supply:
+ description: Negative 5.5V supply
+
+ preset-gpios:
+ description: Display panel reset pin
+
+ treset-gpios:
+ description: Touch panel reset pin
+
+ port: true
+
+required:
+ - compatible
+ - reg
+ - vddio-supply
+ - vsp-supply
+ - vsn-supply
+ - preset-gpios
+ - treset-gpios
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel: panel@0 {
+ compatible = "sony,td4353-jdi-tama";
+ reg = <0>;
+
+ backlight = <&pmi8998_wled>;
+ vddio-supply = <&vreg_l14a_1p8>;
+ vsp-supply = <&lab>;
+ vsn-supply = <&ibb>;
+ preset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
+ treset-gpios = <&tlmm 99 GPIO_ACTIVE_HIGH>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+ };
+ };
+...
--
2.37.3
On 22/09/2022 17:16, Konrad Dybcio wrote:
>>
>> How about bringing them closer to common GPIOs:
>> panel-reset-gpios
>> ?
>>
>>> + description: Display panel reset pin
>>> +
>>> + treset-gpios:
>>
>> touch-reset-gpios
>>
> I can do that. I will however wait with resending in case somebody has comments
> on the .c driver.
Sure, makes sense.
Best regards,
Krzysztof
On 22.09.2022 17:11, Krzysztof Kozlowski wrote:
> On 22/09/2022 15:58, Konrad Dybcio wrote:
>> Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2
>> Compact smartphones.
>>
>> Signed-off-by: Konrad Dybcio <[email protected]>
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +
>> + reg: true
>> +
>> + backlight: true
>> +
>> + vddio-supply:
>> + description: VDDIO 1.8V supply
>> +
>> + vsp-supply:
>> + description: Positive 5.5V supply
>> +
>> + vsn-supply:
>> + description: Negative 5.5V supply
>> +
>> + preset-gpios:
>
> How about bringing them closer to common GPIOs:
> panel-reset-gpios
> ?
>
>> + description: Display panel reset pin
>> +
>> + treset-gpios:
>
> touch-reset-gpios
>
I can do that. I will however wait with resending in case somebody has comments
on the .c driver.
Konrad
>
> Best regards,
> Krzysztof
>
On 22/09/2022 15:58, Konrad Dybcio wrote:
> Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2
> Compact smartphones.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
Thank you for your patch. There is something to discuss/improve.
> +
> + reg: true
> +
> + backlight: true
> +
> + vddio-supply:
> + description: VDDIO 1.8V supply
> +
> + vsp-supply:
> + description: Positive 5.5V supply
> +
> + vsn-supply:
> + description: Negative 5.5V supply
> +
> + preset-gpios:
How about bringing them closer to common GPIOs:
panel-reset-gpios
?
> + description: Display panel reset pin
> +
> + treset-gpios:
touch-reset-gpios
Best regards,
Krzysztof