2021-08-18 06:31:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the i2c tree

Hi all,

After merging the i2c tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
208 | struct device *pdev = vdev->dev.parent;
| ^~~~

Introduced by commit

8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-08-18 06:55:36

by Jie Deng

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the i2c tree


On 2021/8/18 14:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the i2c tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
> drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
> 208 | struct device *pdev = vdev->dev.parent;
> | ^~~~
>
> Introduced by commit
>
> 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")


Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev'
was used in line 237.

https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31

2021-08-18 07:06:16

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the i2c tree

Hi Jie,

On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <[email protected]> wrote:
>
> On 2021/8/18 14:29, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the i2c tree, today's linux-next build (powerpc
> > allyesconfig) produced this warning:
> >
> > drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
> > drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
> > 208 | struct device *pdev = vdev->dev.parent;
> > | ^~~~
> >
> > Introduced by commit
> >
> > 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
>
> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
>

When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-08-18 07:18:10

by Jie Deng

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the i2c tree


On 2021/8/18 15:04, Stephen Rothwell wrote:
> Hi Jie,
>
> On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <[email protected]> wrote:
>> On 2021/8/18 14:29, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the i2c tree, today's linux-next build (powerpc
>>> allyesconfig) produced this warning:
>>>
>>> drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
>>> drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
>>> 208 | struct device *pdev = vdev->dev.parent;
>>> | ^~~~
>>>
>>> Introduced by commit
>>>
>>> 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
>> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
>>
> When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.


Thanks Stephen. I will send an additional patch to fix it.